Commit Graph
111 Commits
Author SHA1 Message Date
Tim van der Lippe 8e12f92229 Use Python version bundled with depot_tools for all scripts
depot_tools ships a "vpython" binary that is added to the $PATH
for all Chromium engineers. This binary is versioned by depot_tools
which we roll in ourselves as part of `gclient sync`.

By using `vpython` instead of `python`, we are no longer depended
on the Python version installed locally and instead use the version
we pull in from DEPS.

R=liviurau@chromium.org

Change-Id: If49a54c24b6cf129ff843cd9ca1140a723a78afb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2571462
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-12-04 14:08:59 +00:00
Tim van der Lippe bfcaca046e Update remaining outdated packages
- Update yargs to 16.1.1
- Update @rollup/plugin-commonjs to 17.0.0
- Update @types/codemirror to 0.0.100
- Update Puppeteer to 5.5.0
- Update Rollup to 2.34.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: Ie3ed95b7c83ec615122643769ff5c53ac4111c09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567910
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-12-02 13:07:39 +00:00
Tim van der Lippe efb716af67 Update linter packages
- Updates stylelint to 13.8.0
- Updates ESLint to 7.14.0
- Updates @typescript-eslint to 4.9.0

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: I207e204607ede782710e042c17d6510c7f696905
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566806
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-12-01 16:04:40 +00:00
Tim van der Lippe e44bf09b3c Speed up running NPM analysis commands
Whenever we do NPM package upgrades, we run `npm run install-deps -- outdated`
or `npm run install-deps -- audit`. However, this would then always
reinstall all packages with `npm ci`, which is timeconsuming, yet
unnecessary as the analysis does not change the installation output.

Therefore, we check if the custom command starts with either outdated
or audit and bail out of unnecessarily reinstalling.

R=jacktfranklin@chromium.org

Change-Id: I475e74ebe626e1c1973399ea65a31ea57f4b6fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2566805
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-12-01 12:47:56 +00:00
Paul Lewis 40e2867bb7 [deps] Adds sinon
R=jacktfranklin@chromium.org

DISABLE_THIRD_PARTY_CHECK=Adding sinon to deps

Change-Id: If47962332a4d9a4b4f0edbe637bca4f9894545ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2562704
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-27 10:25:34 +00:00
Simon Zünd 3870f46933 Update TypeScript to latest stable version 4.1.2
DISABLE_THIRD_PARTY_CHECK="TypeScript update"

R=tvanderlippe@chromium.org

Change-Id: I515d7ffddd47b29740cc96059239a1054a3158b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2558300
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2020-11-25 14:33:57 +00:00
Paul Lewis 34a1660229 Bumps bl to 4.0.3, adds karma-spec-reporter
R=jacktfranklin@chromium.org

DISABLE_THIRD_PARTY_CHECK=Updating 3P deps.

Change-Id: I34a3b906769d1ec19465ec404bc5c9f0c6e1a821
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2552513
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-23 08:19:25 +00:00
Tim van der Lippe afe76b65c9 Update @typescript-eslint packages
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0
none of the breaking changes apply to us.

DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org

Change-Id: Id61788dc65d352f7ecffaea9cf1918141ae3f842
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537959
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-16 15:53:09 +00:00
Tim van der Lippe 59b55bbc11 Update Rollup and rollup-plugin-terser
Rollup-plugin-terser dropped Node <10 and Rollup <2 support
(https://github.com/TrySound/rollup-plugin-terser/releases/tag/v6.0.0)
and upgraded to Terser 5
(https://github.com/TrySound/rollup-plugin-terser/releases/tag/v7.0.0)

DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org

Change-Id: Ifa0085fe5daa052bdfea40720d1852549f4bf316
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537956
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-16 14:46:18 +00:00
Tim van der Lippe dc4637c1a9 Update escodegen and recast
- Escodegen drops Node 6 support (unaffected) and introduces support
for optional chaining
- Recast drops Node <9 support (unaffected)

DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org

Change-Id: I9eb8d294d3ad87a6469da9e0bc1114563abd4f07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537955
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-11-16 14:13:28 +00:00
Tim van der Lippe 97868bd80a Update @types packages
DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I16c3891ec647f9e7e9ede59713a5e3b10ebf2c7a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2537952
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-11-16 12:02:39 +00:00
Tim van der Lippe 16aca394c5 Update ESLint and related packages
Major update breaking changes:
- ESLint 7.0.0 (https://eslint.org/docs/user-guide/migrating-to-7.0.0) now includes
.eslint.rc.js in its list, which is fine for us. Other changes are not applicable
for us.
- eslint-plugin-mocha (https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md#700-may-13-2020)
drops support for ESLint <7, but this CL updates to 7+. Other changes are
not applicable for us.

DISABLE_THIRD_PARTY_CHECK=Updating ESLint
R=petermarshall@chromium.org

Change-Id: I7760e084ef87f73a92f9ea4e075fb4c065047f5a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2534873
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-11-13 12:28:15 +00:00
Peter Marshall 4e161dfc4c Update Mocha to 8.2.1
The changes can be seen here between 8.0.1 and 8.2.1:
https://github.com/mochajs/mocha/releases

There are no breaking changes.

The upgrade will give us the ability to use global fixtures which
may speed up parallel mode. I'm also hoping this fixes a bug with
describe.skip() not working properly for parallel mode.

DISABLE_THIRD_PARTY_CHECK=Update Mocha

Bug: chromium:1101784
Change-Id: Ia052a80c0f6dcefb1a2f21444cdfd3789a3203f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2529149
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
2020-11-10 16:16:58 +00:00
Tim van der Lippe 5226a88fe0 Update karma-related packages
This updates karma to 5.2.3, karma-coverage to the officially
published version 2.0.3 (we were previously relying on a git
commit) and karma-sourcemap-loader to 0.3.8.

DISABLE_THIRD_PARTY_CHECK=Update Karma

R=aerotwist@chromium.org

Change-Id: Iaa365379d7c2c6eb9145b1507be1a0a3ae812359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2527043
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-11-09 17:42:16 +00:00
Simon Zünd 5f6c0652cc Update TypeScript to 4.1.1-rc
DISABLE_THIRD_PARTY_CHECK="TypeScript update"

R=tvanderlippe@chromium.org

Bug: chromium:1145510
Change-Id: I79473360bc94087d19b5b88091f6255d490c1485
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2517570
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2020-11-04 14:22:08 +00:00
Johan Bay f035c3a5de Roll Puppeteer from 5.3.1 to 5.4.1
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Change-Id: I6c0d6e92cffbec8c0ee17dcad2aec9cbebdbc29c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2512232
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@google.com>
2020-11-02 13:25:30 +00:00
Tim van der Lippe 6541ce6a4c Add README.chromium to node_modules
This is to make sure that automated tooling correctly deduces that
`node_modules/` hosts third_party content.

DISABLE_THIRD_PARTY_CHECK=NPM infrastructure update
R=adetaylor@chromium.org

Change-Id: Ie7c07cfbff0af461cf6b8774633c1fcc3515d332
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505134
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
2020-10-28 17:57:07 +00:00
Jan Scheffler a93c437703 Reland "[Puppeteer] Update puppeteer to v.5.4.0"
This reverts commit 89a6d325b7

Original change's description:
> Revert "[Puppeteer] Update puppeteer to v.5.4.0"
>
> This reverts commit a759e62ec6.
>
> Reason for revert: breaks CQ
>
> Original change's description:
> > [Puppeteer] Update puppeteer to v.5.4.0
> >
> > Change-Id: I831d23e24f840d1898959814809839a34b6b9eb7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2502001
> > Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> > Reviewed-by: Mathias Bynens <mathias@chromium.org>
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
>
> TBR=aerotwist@chromium.org,mathias@chromium.org,janscheffler@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: Idc901e648ddaba20697c4b4b5d1580f6e07087e6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2503514
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Commit-Queue: Mathias Bynens <mathias@chromium.org>

TBR=aerotwist@chromium.org,mathias@chromium.org,janscheffler@chromium.org,jacktfranklin@chromium.org


Change-Id: Ib7ffa336327ac5c0b133cd6fc1660d03d16885d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2505652
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
2020-10-28 15:30:47 +00:00
Mathias Bynens 89a6d325b7 Revert "[Puppeteer] Update puppeteer to v.5.4.0"
This reverts commit a759e62ec6.

Reason for revert: breaks CQ

Original change's description:
> [Puppeteer] Update puppeteer to v.5.4.0
>
> Change-Id: I831d23e24f840d1898959814809839a34b6b9eb7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2502001
> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,mathias@chromium.org,janscheffler@chromium.org,jacktfranklin@chromium.org

Change-Id: Idc901e648ddaba20697c4b4b5d1580f6e07087e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2503514
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-10-28 07:24:20 +00:00
Jan Scheffler a759e62ec6 [Puppeteer] Update puppeteer to v.5.4.0
Change-Id: I831d23e24f840d1898959814809839a34b6b9eb7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2502001
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-27 16:32:38 +00:00
Philip Pfaffe 8e8994436d Fix caching in emscripten download script
Change-Id: I14376ad9e9856a28a57ed266fff2a83a1fbeef16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2485082
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2020-10-20 09:53:30 +00:00
Philip Pfaffe 3351394f22 Update DEPS and gitignore for building with emscripten
Drive-by: Address post-commit comments from crrev.com/c/2409951

Bug: chromium:1128888
Change-Id: I47a8f0c2deee7db15c574195f45a362c4a6d9fbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466179
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
2020-10-15 08:14:33 +00:00
Philip Pfaffe 02376092a3 Download emscripten-releases binaries for building wasm tests
This CL adds a DEPS hook that will download tagged emscripten-releases
binaries from googlestorage that will be used to build wasm debugging
tests.

Bug: chromium:1128888

Change-Id: Ib5d0488fe3fe2c3514faa9f76b07e84c51296c25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2409951
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2020-09-29 11:28:38 +00:00
Philip Pfaffe f56f06bae0 Delete back_end
Work on the external symbols backend is discontinued, so delete
it from the repo.

Change-Id: Id590f849a98bf8feb1ba31e81912c575ea0aedfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2429774
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-09-25 13:28:48 +00:00
Maksim Sadym 627aff4a25 Roll Puppeteer from v5.2.1 to v5.3.1
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

What was done:
* updated puppeteer to v5.3.1 in `scripts/deps/manage_node_deps.py`
* run `python scripts/deps/manage_node_deps.py`
* reverted not related changes

Bug: 1130513
Change-Id: I500e46b9f43e7139bce35aafa10d7b891364caa9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2422954
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Maksim Sadym <sadym@chromium.org>
2020-09-22 19:39:57 +00:00
Tim van der Lippe 6b739ed467 Upgrade TypeScript to 4.1.0-beta
DISABLE_THIRD_PARTY_CHECK=Update TypeScript
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: I7ff488de6b844a1503a421399417fd8b32705653
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2421689
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-09-21 12:56:40 +00:00
Tim van der Lippe ab0853cf8a Load axe_core_test_runner as module
This requires us to move third_party/axe-core into front_end/third_party,
as we are loading these files in the browser.

DISABLE_THIRD_PARTY_CHECK=Moving source code around
R=aerotwist@chromium.org

Bug: 1105476
Change-Id: I139c53af1a12ad2a7df7381c3d01b0c4e0f72c28
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2406159
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-09-14 12:07:57 +00:00
Wolfgang Beyer cdedf581e5 Revert "Update Mocha and rollup-plugin-terser"
This reverts commit ecc4ecb65c.

Reason for revert: This CL is suspected of breaking the roll into
chromium (https://crbug.com/1121242#c2).

Original change's description:
> Update Mocha and rollup-plugin-terser
> 
> These two packages had NPM advisories filed against them. Luckily,
> we can upgrade to versions where they are fixed.
> 
> The upgrade of rollup-plugin-terser includes the upgrade to Terser 5.
> Looking at its changelog (https://github.com/terser/terser/blob/master/CHANGELOG.md#v500-beta0)
> we seem to not be affected. Our build also works as expected.
> 
> DISABLE_THIRD_PARTY_CHECK=Update node modules
> R=​petermarshall@chromium.org
> 
> Change-Id: I6974a73d92a1a210b705246053be5c2af268605b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2372148
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>

TBR=petermarshall@chromium.org,tvanderlippe@chromium.org

Change-Id: I969ca281c77d299038332f93ffd477925e191073
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2374207
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
2020-08-25 08:29:20 +00:00
Tim van der Lippe ecc4ecb65c Update Mocha and rollup-plugin-terser
These two packages had NPM advisories filed against them. Luckily,
we can upgrade to versions where they are fixed.

The upgrade of rollup-plugin-terser includes the upgrade to Terser 5.
Looking at its changelog (https://github.com/terser/terser/blob/master/CHANGELOG.md#v500-beta0)
we seem to not be affected. Our build also works as expected.

DISABLE_THIRD_PARTY_CHECK=Update node modules
R=petermarshall@chromium.org

Change-Id: I6974a73d92a1a210b705246053be5c2af268605b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2372148
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-08-24 12:14:14 +00:00
Tim van der Lippe 5f83b28dd7 Update TypeScript to 4.0.2
DISABLE_THIRD_PARTY_CHECK=Updating TypeScript
R=szuend@chromium.org

Fixed: 1120303
Change-Id: I342cfacaf25c4b450bb00703454fe69db4b6f3cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2367944
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2020-08-21 13:17:14 +00:00
Ilya Sherman a46c048cda Pull code for formatting the X-Client-Data header from Chromium/upstream
This is the devtools side of https://chromium-review.googlesource.com/c/chromium/src/+/2360517

R=mathias

Bug: chromium:1103854
Change-Id: I5ec32a4e84a0f873ec5372579728a94f47a83463
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2361093
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
2020-08-19 05:25:27 +00:00
Peter Marshall a29e76f622 tests: Use source maps for better error output for e2e tests
Explicitly depend on the source-map-support package. Other packages
already used this indirectly so the files already exist in node_modules.

Add source-map-support/register to the require list for mocha which
means every e2e test will have source mapped error stacks by default.

Bug: 1104096
Change-Id: Id185ee76e82c100f1f763195673759f3f2319090
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332222
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
2020-07-31 12:45:19 +00:00
Mathias Bynens 4ceefeb36e Add support for rolling ClientVariationsParser.js
Bug: chromium:1103854
Change-Id: Ie5cebb77290727aadf9e3074f4c95306119df17c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2316074
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-07-25 08:16:54 +00:00
Johan Bay 9dd9a4b882 Roll Puppeteer from v4.0.0 to v5.2.1
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Change-Id: Ic6a2b99314bc3cd05f6283e261d8aa952bc56984
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2310451
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-07-22 06:54:36 +00:00
Tim van der Lippe bb7978bb9e Update several @types packages
These @types packages were outdated. Additionally, make sure to
includes these files in the `typescript.gni`, to cause TSC to
rerun whenever they change.

DISABLE_THIRD_PARTY_CHECK=NPM updates
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: Idce2ec5d48e280c56b496599b56d5cc4c30df404
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297397
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-07-15 10:01:04 +00:00
Jack Franklin 264237a972 Upgrade TypeScript ESLint dependencies.
DISABLE_THIRD_PARTY_CHECK=node_modules update

This was an attempt to fix https://crbug.com/1102821 however the issue still
appears. I expect it will until TS4.0 is out of beta and the ecosystem catches
up.

We were however on a much older version so I took the opportunity to update us
to the current latest version.

Change-Id: I8332409e9de50d60f6284eef5098b55a7f9535c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2299995
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-07-15 09:29:44 +00:00
Tim van der Lippe 8b21270f6e Add @types/codemirror
They are used in the formatter_worker files

DISABLE_THIRD_PARTY_CHECK=Add node package
R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1098730
Change-Id: I3c236386dfccd2c12b6379f8bbb5bc9232061734
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2294984
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-07-13 15:34:39 +00:00
Peter Marshall 9c4cbce5ab Set env to disable chromium download in manage_node_deps.py
Previously this was set in package.json which assumed the script would
not be run directly.

Set it in the script instead so it can be run directly.

Change-Id: I96d7f9d4589585d1a83655c6b1967e1a89ba7958
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279843
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-07-06 14:30:42 +00:00
Peter Marshall 0b95ea162f Update Mocha to 8.0.1
Breaking changes here https://github.com/mochajs/mocha/releases/tag/v8.0.0
seem fine.

DISABLE_THIRD_PARTY_CHECK=Update Mocha

Bug: chromium:1101784
Change-Id: Idc75c94f9a923e2b0ca13d1d1331540cb1c5d3a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279830
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
2020-07-03 09:50:38 +00:00
Tim van der Lippe f171bbbae0 Add @rollup/plugin-commonjs to NPM dependencies
DISABLE_THIRD_PARTY_CHECK=Add NPM dependency

R=vidorteg@microsoft.com

Change-Id: I3fb90b1f4c661125a1b71129fdc45c688dc018ff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2279833
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
2020-07-02 17:56:00 +00:00
Tim van der Lippe c1e0cf3933 Update TypeScript to 4.0.0-beta
DISABLE_THIRD_PARTY_CHECK=Update TypeScript
R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ie636e205ee3b06a6189872088a1fa962beddd980
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2273178
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-06-29 16:24:33 +00:00
Tim van der Lippe 7989857282 Add @types/estree to dependencies
These types will be used in the formatter_worker/ which references
types like `ESTree.Node`

DISABLE_THIRD_PARTY_CHECK=New npm dependency
R=jacktfranklin@chromium.org

Bug: 1098730
Change-Id: I0d8868c5f528a8eb11431741b7c98f15dd3bc2ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2264119
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-06-24 16:03:29 +00:00
Mathias Bynens 779b5ea094 Roll Puppeteer v4.0.0
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Change-Id: I37d4670cf18e26e8caa8a5b1ca19c8f187244bac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259851
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-06-23 12:40:26 +00:00
Mathias Bynens 8604a98e45 Add stylelint-config-standard dependency
DISABLE_THIRD_PARTY_CHECK=updating node_modules deps

Bug: chromium:1083142
Change-Id: Ic4a2a914da2f739c304c1607aa17002548980e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259834
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-06-23 09:29:46 +00:00
Mathias Bynens 1b2c5e463e Enable stylelint on presubmit
Bug: chromium:1083142
Change-Id: I74136f2ba5b74d4385760e157e2495d706cb5c35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2248184
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-06-18 10:41:46 +00:00
Mathias Bynens 79e2cf0633 Add stylelint dependency
This also adds CC-BY-4.0 to the list of accepted licenses.

DISABLE_THIRD_PARTY_CHECK=update dependencies

Bug: chromium:1083142
Change-Id: I8612de2fba52dae32eeb71af79d5aacfde52142b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2220097
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2020-06-11 06:20:04 +00:00
Tim van der Lippe d79d79b838 Fix node_modules/OWNERS file after updating a dependency
We were deleting the file, since we remove the whole `node_modules`
folder. Just like clang-format, we should add it back after
the installation process is completed.

DISABLE_THIRD_PARTY_CHECK=Fix OWNERS file
R=jacktfranklin@chromium.org

Change-Id: Ieb3366160f962db8c6af682d0b186ece941b1031
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218014
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2020-05-27 15:33:16 +00:00
Jack Franklin 212c527f90 Upgrade to TypeScript 3.9.3
I was hitting a bug in 3.9.2 with the breadcrumbs CL [1] that is fixed
in 3.9.3 via this PR [2]. (I've verified locally that it is fixed).

[1]: https://github.com/microsoft/TypeScript/issues/38535
[2]: https://github.com/microsoft/TypeScript/pull/38577

DISABLE_THIRD_PARTY_CHECK=typescript update


Change-Id: Ia874e5936a5bbf0bf26f751ab746976f71910f25
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218013
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
2020-05-27 15:13:36 +00:00
Brandon Goddard f8f37d164e Automatic Symlinked workflow
This CL introduces an alternate approach to the integrated workflow
that allows users to use a single gclient project to manage both
chromium/src and devtools-frontend.

It also adds a scripts and instructions for how to install as a hook
to ensure that running `gclient sync -D` no longer removes
the symlink to the devtools-frontend when using the integrated workflow

*Note that the hook can be used regardless of using the single gclient
project if the path to the non-symlinked devtools frontend is inserted
in the .gclient project file for chromium/src

Change-Id: I235ff713964fd02d9cec40e07e88e9d7b68dcf16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209366
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2020-05-26 19:38:30 +00:00
Tim van der Lippe 97eeaf0176 Add rollup-plugin-terser
DISABLE_THIRD_PARTY_CHECK=Add node_modules
R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1084578
Change-Id: I70e03fa74f53960a17c884a2bac4027382d66525
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2208135
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2020-05-21 09:47:07 +00:00