zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
2,884 Commits 43 Branches 79 Tags
d5a3755f19aa248cffbcf61f1628362aaa6c0377
Commit Graph
19 Commits
Author SHA1 Message Date
Simon Zünd 182134236e Rename namespace import for protocol_client to ProtocolClient 
R=tvanderlippe@chromium.org

Bug: chromium:1011811
Change-Id: Idf3e9eb8f6d52db78f563de53b7576ec6c9b9cdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107557
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-03-19 12:08:52 +00:00
Tim van der Lippe ba26b2b503 Run ESLint on the scripts directory 
We weren't running ESLint on this directory and, as it turns out, there
are quite a few linter errors in this folder.

R=jacktfranklin@chromium.org

Change-Id: Ic6cb9f6ad4858f69114e0c433a954041215b49e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096705
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-03-11 14:47:51 +00:00
Tim van der Lippe c53ba5018f Only consider module.json files for remove unused globals 
This will allow us to cleanup all -legacy files with any unused globals
that are not referenced in both the layout tests or module.json files.

Bug: 1006759
Change-Id: I4884884529c4d08fd19a8e0db9edd758f6eacf03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055063
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-02-14 15:31:44 +00:00
Tim van der Lippe 22a64d3fe4 Update replace-internal-references to accept multiple folders 
This allows us to specify multiple folders at the same time, doing only
1 pass per folder.

Bug: 1006759
Change-Id: I522249c3490f36c7d856a56c992d0393cc9738e4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2018945
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-24 13:46:38 +00:00
Tim van der Lippe ddbec81f2d Map imports to Protocol to ProtocolModule 
There is a name-clash on the Closure type-defs generated from CDP, which
also use the Protocol namespace. Therefore, for es-imports we should use
`import * as ProtocolModule` instead.

Bug: 1006759
Change-Id: I1e7e92825fdafe56c4f5274e520650001789014c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016755
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-23 13:22:20 +00:00
Tim van der Lippe 0cfd3dc2af Update remove global scripts to run on legacy files 
Also make sure we take into account the layout tests

Bug: 1006759
Change-Id: I6b819876034aae7019e62b1b34ca6adeb50326b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2002606
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-16 10:35:44 +00:00
Paul Lewis b4e2a0741b Check for self.X = self.X || {} in migration script 
Bug: 1006759
Change-Id: I741093c412e6ef47b0154b0202bda56ffd07328c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993460
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 17:11:01 +00:00
Tim van der Lippe 472675db85 Migrate data_grid/ to ESM internally 
Bug: 1006759
Change-Id: Idb20304bcf3e72e4a0bba242e847e90ff9b8a8c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1993342
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-01-09 15:04:51 +00:00
Paul Lewis 26afc1e4f9 Adds migration script for refs 
This script expects that -legacy.js files are in place for a
given module. So, for example, if migrating front_end/search
one would run move-side-effects-to-legacy for search, then follow
that with this script, replace-internal-references, which will
step through the files in front_end/search and update all globals
to refer to imports.

This script also supports cross-module rewrites, such that if a
namespace is passed through, the -legacy.js file for the namespace
will be loaded instead and used for the replacements.

Bug: 1006759
Change-Id: I7af5e1343a028aed82d5c3f536be886011cf9a2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1958525
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-12-10 13:47:05 +00:00
Paul Lewis da0fab38e1 Adds migration script to moving side-effects to legacy file 
TBR=tvanderlippe@chromium.org
Bug: 1006759
Change-Id: I145e029b427900995468e86a522085553cb5c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1953769
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2019-12-09 10:59:22 +00:00
Tim van der Lippe 5e2f45a379 Add script to remove unused globals 
It Traverses all expression statements that put stuff on the global
scope and checks if it is only used once (e.g. in that particular
assignment). Anything that is only exported but never used is deleted.

This works for extensions declared in the module.json as well.

Change-Id: Ie3d9759da8593f8c66f1c12ba2e8ee1724f240d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1942289
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2019-11-28 17:40:34 +00:00
Paul Lewis f16142c532 Migrate accessibility/ to esm 
Bug: 1006759
Change-Id: I9544f28e103acf0869cd6b3d98681b5788498ae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1893084
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-07 18:06:05 +00:00
Paul Lewis 3940ef25f1 Move data_grid over to ESM 
Bug: 1006759
Change-Id: I02a7fc01bff612cf057c918df7449734bba241b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1893076
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-07 14:42:25 +00:00
Yang Guo 75beda900f Move test scripts to scripts/test 
R=aerotwist@chromium.org, liviurau@chromium.org, machenbach@chromium.org

Bug: 1018122
Change-Id: I7cc3a1a9ab01c649b3c7fe8ba5d5254adc631634
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880033
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
 2019-10-28 07:57:59 +00:00
Tim van der Lippe a4d448c312 Migrate console_counters/ to ESM 
- Also upgrade the refactor script to automatically add the
extensionpoint to the BUILD.gn to save myself some typing.

Bug: 1006759
Change-Id: I3f789f96122569141194ce26ac288f01af68f6e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852209
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#704600}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e55e98bc0ca76229380e3bca5a78e15d953da0c5
 2019-10-10 13:38:29 +00:00
Tim van der Lippe 50cfa9b19d Migrate host/ to ESM 
Bug: 1006759
Change-Id: Ib72e0acbb20c4579e708cd79a67ffd0bc2073b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829102
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#701509}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b2641f7a9893b50ab7f74d8bc5b7ca7743b0a530
 2019-10-01 10:40:58 +00:00
Tim van der Lippe 7ca9ec190d Copy individual symbols and comments for Closure 
Closure was unhappy with the `Object.assign` solution. Instead, use
individual assignments and add the relevant comments, so that Closure
can understand what is going on.

Sample output:

```
/*Legacy exported object*/
self.UI = self.UI || {};

/*Legacy exported object*/
UI = UI || {};

//TODO(http://crbug.com/1006759): Add type information if necessary
UI.TextEditor = TextEditor;

//TODO(http://crbug.com/1006759): Add type information if necessary
UI.TextEditor.prototype = prototype;

/** @enum {symbol} */
UI.TextEditor.Events = Events;
```

Bug: 1006759
Change-Id: Ib0e571cc027f544b316a3e3ccf8c3d606273d887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819248
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#698878}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c1c9f965bfcf2dbcd8f868414874c085f4ff9515
 2019-09-23 13:39:17 +00:00
Tim van der Lippe 64bc95bd4b Automatically generate module file with exports 
Since we are reading the file names anyways, we can also generate the
actual module name. Also delete the UI.js, since we will be generating
that now (albeit lowercase).

Change-Id: I16730392aa49927ac32da939a88399cc6ac49340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810999
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#698034}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e80d12cb681bcd49518ec50763ede737bc86a136
 2019-09-19 15:35:50 +00:00
Tim van der Lippe 29011f8a88 Introduce migration script for JavaScript modules 
Example invocation of the script:

./refactor-folder-to-es-modules.sh ui

It will consequently refactor all files in the ui folder to JavaScript
modules. It will also update the BUILD.gn variables to remove the
references from the old all_devtools_files into the new modules
variables.

Change-Id: I35ad6360b15d1aff250afffc8a28774c4e8cc1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808867
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#697602}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6d48f36bc75c558ac1ee899ccb20877b800e9410
 2019-09-18 14:33:56 +00:00