zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-09 21:28:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,872 Commits 45 Branches 79 Tags
d5de9a0d886caa6ecf8f29861663cd49f7ef2b24
Commit Graph
12 Commits
Author SHA1 Message Date
Tim van der Lippe 207e2f9fdc Migrate browser_debugger to devtools_entrypoint 
R=jacktfranklin@chromium.org

Bug: 1101738
Change-Id: I2baadadc23f935725272bdb73f256b6827f58f57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2390620
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-09-02 15:05:20 +00:00
Sigurd Schneider 965b1ffc56 Revert "Migrate browser_debugger to devtools_entrypoint" 
This reverts commit 8419f16834.

Reason for revert: Doesn't compile:
https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/2171

Original change's description:
> Migrate browser_debugger to devtools_entrypoint
> 
> Bug: 1101738
> Change-Id: Ia5a5b8a6fff3607d787df23d31264552c55267bf
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335069
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

TBR=aerotwist@chromium.org,jacktfranklin@chromium.org

Change-Id: I60f22d4cd485b3b555ce8e476d58bb01abccbff9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101738
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336718
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-08-04 13:01:15 +00:00
Paul Lewis 8419f16834 Migrate browser_debugger to devtools_entrypoint 
Bug: 1101738
Change-Id: Ia5a5b8a6fff3607d787df23d31264552c55267bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335069
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-08-04 12:04:53 +00:00
Mathias Bynens 5e43b27e8b Reformat module.json files 
This patch makes it so that all module.json files use the same
consistent indentation that matches .editorconfig and the rest
of the codebase. At the request of reviewers, one such file
(front_end/emulated_devices/module.json) has been excluded
from this patch. It will be reformatted in a separate CL.

Note that this patch does not “roll CodeMirror”, although a
pre-commit hook forces me to include that phrase in the commit
message because the module.json file in the relevant folder is
modified.

Bug: chromium:1070492
Change-Id: Ib31ed5232461e2f80bf05f31105fc919f6639b0a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2127007
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-14 05:35:23 +00:00
Jack Lynch 0a882882e4 Highlight DOM breakpoints when hit 
This CL fixes an issue where one or both of the two instances of the DOM
breakpoints pane (in Sources and Elements) fail to update when a
breakpoint is hit. There's a video in the linked bug showing more
specific repro steps, but the issue stems from three different
extensions in browser_debugger.json that reference
DOMBreakpointsSidebarPane: two views and a ContextFlavorListener. Unlike
every other view in the devtools, these ones define a factoryName rather
than a className. This makes the devtools create separate instances for
each rather than using runtime.sharedInstance(), which breaks
UI.Context._dispatchFlavorChange(), which does rely on
runtime.sharedInstance().

In order to make _dispatchFlavorChange() work properly with both the
Elements and Sources panel views, I replaced their factoryNames with
classNames, i.e. made them share an instance. Some minor changes to
ContainerWidget and _ExpandableContainerWidget were needed to make sure
the shared instance actually shows up where needed, but everything now
works as expected. An alternative would be to rework
Extension.instance() and ContextFlavorListener, but that seems more
invasive.

Bug: 973251
Change-Id: I288dea794518605f8f93c28c7826372dbaea2e1f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1984805
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
 2020-01-13 17:23:55 +00:00
Paul Lewis 2a4f9fe07d Migrates browser_debugger to ESM internally 
Bug: 1006759
Change-Id: Iae67cbad44cfebe3ceb4353f32d9e2e4024b41bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1991631
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-01-09 16:21:21 +00:00
Paul Lewis 7f7a92088c Migrates browser_debugger/ to esm 
Bug: 1006759
Change-Id: I6fd8ea8fb749bf1231b481a8b311f0370fe9e401
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934217
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2019-11-26 16:26:56 +00:00
Pavel Feldman a06cbef9f6 Reland "DevTools: allow showing views above and below the Sources sidebar." 
This reverts commit 41f9647f5be04f00b08991980ce92a84f45fb990.

Reason for revert: applying fix.

Original change's description:
> Revert "DevTools: allow showing views above and below the Sources sidebar."
>
> This reverts commit d21d2ed3a028353e143dfa6708e6c7bbf13fa9fc.
>
> Reason for revert: Causing devtools_eslint failure
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout
>
> Original change's description:
> > DevTools: allow showing views above and below the Sources sidebar.
> >
> > Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817
> > Reviewed-on: https://chromium-review.googlesource.com/c/1357513
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#612830}
>
> TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1358118
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613013}

TBR=dgozman@chromium.org

Change-Id: I0e4cd1fe9585f7ccd365cc449ca0429e0b031141
Reviewed-on: https://chromium-review.googlesource.com/c/1358045
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613020}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5e71f37a822fedb49fc168fd3658195445613be5
 2018-12-03 08:08:01 +00:00
calamity f9bd7f1727 Revert "DevTools: allow showing views above and below the Sources sidebar." 
This reverts commit d21d2ed3a028353e143dfa6708e6c7bbf13fa9fc.

Reason for revert: Causing devtools_eslint failure
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout

Original change's description:
> DevTools: allow showing views above and below the Sources sidebar.
> 
> Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817
> Reviewed-on: https://chromium-review.googlesource.com/c/1357513
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612830}

TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf
Reviewed-on: https://chromium-review.googlesource.com/c/1358118
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613013}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 41f9647f5be04f00b08991980ce92a84f45fb990
 2018-12-03 06:44:35 +00:00
Pavel Feldman cca34307f0 DevTools: allow showing views above and below the Sources sidebar. 
Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817
Reviewed-on: https://chromium-review.googlesource.com/c/1357513
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612830}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d21d2ed3a028353e143dfa6708e6c7bbf13fa9fc
 2018-11-30 23:09:39 +00:00
Pavel Feldman c9060ea409 DevTools: move overrides and content scripts into browser_debugger, add drawer split. 
Change-Id: I9495216a14e15d35fd55894b48a19f616a649213
Reviewed-on: https://chromium-review.googlesource.com/1034196
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554695}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2431f4ba31873e17c1abfa5d7cc9f29ba8dca4d0
 2018-04-30 04:42:18 +00:00
Blink Reformat 4c46d0969f The Great Blink mv for source files, part 2. 
Move and rename files.

NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true

Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
 2018-04-07 15:32:37 +00:00