Commit Graph
2 Commits
Author SHA1 Message Date
Alex Rudenko 91403e7b5c Reuse contrastRatio and rgbaToHsla
This CL extracts contrastRation and rgbaToHsla helpers to ColorUtils
and makes use of the extracted helpers in DevTools and inspector
overlay.

Fixed: 1078267
Change-Id: I467f1a7d7bfae0051cec17a732f62f1cacb5fa66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2230498
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2020-06-04 07:46:11 +00:00
Alex Rudenko 4f8e4f9344 Reuse blendColors util
This CL extracts blendColors into a new utils file (more lightweight
function utils compared to Color.js) and reuses it in the overlay code.
Also, it adds an exception to eslint module import rules for the
inspector overlay folder because inspector overlay benefits from
granular imports instead of complete namespace imports.

Bug: 1078267
Change-Id: I01ec8f295da8bfac0b57b9dd2661ca9f798de869
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2228514
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2020-06-04 06:23:51 +00:00