Accessibility testing revealed the following issues within the tool:
1. no focus indicator on javascript VM instances list
This change:
changes current selected/hover and adds selected but inactive color to match treeoutline in Element
Bug: 963183
Workflow gif: https://imgur.com/a/lHNTOP7
Change-Id: Iaed79d7166bf70011711be548ba66c65a57922da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678946
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#690483}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 522709bc5b3158fdaef516f391d382d7321e505f
These css rules used classes that don't exist anywhere in the
javascript. A script was written to find them, but manually checking
is still needed because some scripts generate class names by
string concatenation like 'icon-' + iconType
Change-Id: I15c4f26451b9fa371b366a8977021e2af7eca449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618043
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#661630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e6f259d6e2834c9b0e2cbb0fdd7c9703e1fc6968
- Console Sidebar's icons are now masks, use the same background
color as other navigator icons.
- Inactive selections used to have the exact same color as toolbar
backgrounds, which made them invisible. Now inactive selections in
dark theme are brighter.
Light (l in hsl) values in dark theme for:
ElementsTreeOutline > Navigators/Sidebars > Inactive tree selections
Before: 14% > 20% > 20%
After: 14% > 20% > 29%
Screenshot: https://imgur.com/a/Dn4e1Hv
Bug: none
Change-Id: I1caf8e53a58352a92d3efc143c55b274246253b6
Reviewed-on: https://chromium-review.googlesource.com/1229196
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591921}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d465724a64d535cfcf53176bb68860810a3a7e3b