Tim van der Lippe
|
d1a00aacb9
|
[globals] self.UI.context
R=jacktfranklin@chromium.org
Bug: 1058320
Change-Id: Icc1d806782e7624fff02e719670a2cca59070ddd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2364594
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
|
2020-08-19 16:24:38 +00:00 |
|
Paul Lewis
|
6d4ebb2006
|
Reland "Reland "Updates elements to devtools_module""
This reverts commit 340bd16cd3.
Reason for revert: devtools_pre_built no longer makes hardlinks
Original change's description:
> Revert "Reland "Updates elements to devtools_module""
>
> This reverts commit 04858cf7dd.
>
> Reason for revert: This seems to trigger the known issue that
> TSC is rewriting source files because of left-over hard-links.
> See https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/2582
>
> To reproduce locally, check out the commit before this revision,
> do a clean build, then check out this revision, and do a build.
> This will succeed but rewrite source files (which it shouldn't).
>
>
> Original change's description:
> > Reland "Updates elements to devtools_module"
> >
> > This reverts commit 22d876ca02.
> >
> > Reason for revert: Build issues on bots should be fixed
> >
> > Original change's description:
> > > Revert "Updates elements to devtools_module"
> > >
> > > This reverts commit 81e818fad8.
> > >
> > > Reason for revert: Anticipating build errors on bots
> > >
> > > Original change's description:
> > > > Updates elements to devtools_module
> > > >
> > > > Bug: 1101738
> > > > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > >
> > > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> > >
> > > Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1101738
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> > > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> >
> > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> >
> > # Not skipping CQ checks because this is a reland.
> >
> > Bug: 1101738
> > Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
>
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: Iabfbe2aad94033078eac41338d64ca069f49332f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101738
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335273
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
TBR=sigurds@chromium.org,aerotwist@chromium.org,jacktfranklin@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: 1101738
Change-Id: I42579d6cac06ec45377789253588ba94ee72a226
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336715
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2020-08-10 09:15:45 +00:00 |
|
Sigurd Schneider
|
340bd16cd3
|
Revert "Reland "Updates elements to devtools_module""
This reverts commit 04858cf7dd.
Reason for revert: This seems to trigger the known issue that
TSC is rewriting source files because of left-over hard-links.
See https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Linux/2582
To reproduce locally, check out the commit before this revision,
do a clean build, then check out this revision, and do a build.
This will succeed but rewrite source files (which it shouldn't).
Original change's description:
> Reland "Updates elements to devtools_module"
>
> This reverts commit 22d876ca02.
>
> Reason for revert: Build issues on bots should be fixed
>
> Original change's description:
> > Revert "Updates elements to devtools_module"
> >
> > This reverts commit 81e818fad8.
> >
> > Reason for revert: Anticipating build errors on bots
> >
> > Original change's description:
> > > Updates elements to devtools_module
> > >
> > > Bug: 1101738
> > > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> >
> > TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
> >
> > Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1101738
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
>
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: 1101738
> Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
Change-Id: Iabfbe2aad94033078eac41338d64ca069f49332f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101738
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335273
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
|
2020-08-03 14:47:19 +00:00 |
|
Paul Lewis
|
04858cf7dd
|
Reland "Updates elements to devtools_module"
This reverts commit 22d876ca02.
Reason for revert: Build issues on bots should be fixed
Original change's description:
> Revert "Updates elements to devtools_module"
>
> This reverts commit 81e818fad8.
>
> Reason for revert: Anticipating build errors on bots
>
> Original change's description:
> > Updates elements to devtools_module
> >
> > Bug: 1101738
> > Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
>
> TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
>
> Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101738
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: 1101738
Change-Id: Ia0d06bb75f2610459f4d0b31ff6b770b1031d982
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2335060
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
|
2020-08-03 14:01:07 +00:00 |
|
Paul Lewis
|
22d876ca02
|
Revert "Updates elements to devtools_module"
This reverts commit 81e818fad8.
Reason for revert: Anticipating build errors on bots
Original change's description:
> Updates elements to devtools_module
>
> Bug: 1101738
> Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
TBR=aerotwist@chromium.org,jacktfranklin@chromium.org
Change-Id: I3e36a1520e34be3ce1779ecdf2b4cead6a293971
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101738
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2332815
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
|
2020-08-03 11:24:30 +00:00 |
|
Paul Lewis
|
81e818fad8
|
Updates elements to devtools_module
Bug: 1101738
Change-Id: I294d366c95a3b5dc7ac5b757855846a7b31ac60b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2329779
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
|
2020-08-03 11:07:47 +00:00 |
|
Tim van der Lippe
|
97611c9403
|
Migrate elements/ to import cross-module
Bug: 1006759
Change-Id: I253ab8e4768cf57aa017dca98dfff851eeec8cec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2052169
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
|
2020-02-13 14:26:58 +00:00 |
|
Paul Lewis
|
d990734442
|
[Global] Update refs to UI.context
Bug: 1006759
Change-Id: I4a405fb1d80f6a384a311a3482c37f943238b73f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2019137
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
|
2020-01-24 14:25:48 +00:00 |
|
Jack Lynch
|
7bc9bf2b07
|
Performance Event Log link accessibility
This CL makes the links in the Performance panel Event Log details view,
shown to the right in [1], tabstops so that they can be accessed by
keyboard users.
[1] https://gyazo.com/de063c6b02c4d7580807338a6371f9f7
Bug: 963183
Change-Id: I718805bc31fbfa681a035909358345e96d3aa8bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891710
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
|
2020-01-13 17:53:35 +00:00 |
|
Tim van der Lippe
|
aabc830090
|
Migrate elements/ to use ES-imports
This moves the side-effects to elements-legacy.js (which is lazily
loaded by the Runtime) and resolves all internal references using
ES-imports.
Bug: 1006759
Change-Id: I911a3a31f12e68488c9cd8d807ef03a9c7286668
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1960447
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
|
2019-12-10 16:00:15 +00:00 |
|
Tim van der Lippe
|
13f71fb5e7
|
Reland "Migrate elements/ to ESM"
This reverts commit 9fd15ddbd0.
Reason for revert: Fixed browser tests loading behavior
Original change's description:
> Revert "Migrate elements/ to ESM"
>
> This reverts commit 8fefb2ca13.
>
> Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.
>
> Original change's description:
> > Migrate elements/ to ESM
> >
> > Bug: 1006759
> > Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> > Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1006759
> Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
Change-Id: Iba84f5230f20a86b2de75b84115fcb10aeea534e
Bug: 1006759
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937029
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
|
2019-11-29 13:04:20 +00:00 |
|
Yang Guo
|
9fd15ddbd0
|
Revert "Migrate elements/ to ESM"
This reverts commit 8fefb2ca13.
Reason for revert: broke browsertest https://ci.chromium.org/p/chromium/builders/try/linux-rel/250464 and blocking roll.
Original change's description:
> Migrate elements/ to ESM
>
> Bug: 1006759
> Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
TBR=aerotwist@chromium.org,tvanderlippe@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1006759
Change-Id: I16a1fd9851391a6080c5376ca35866402b0bc445
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1937027
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
|
2019-11-26 16:48:06 +00:00 |
|
Tim van der Lippe
|
8fefb2ca13
|
Migrate elements/ to ESM
Bug: 1006759
Change-Id: Ie9144a22562eb3ae3341a285f5ad16f3d630896c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1934212
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
|
2019-11-25 15:18:14 +00:00 |
|
Connor Clark
|
5f26721587
|
[DevTools] Display JS stack trace for DOM Node creation
Off by default, enabled via experiment.
Change-Id: I3c6503ce8c2d9102b4ccc3e71010e7d20c49a12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687474
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#681542}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 16ad750d1405f61faf1daaff6fa33816c1a4e4d0
|
2019-07-26 23:59:11 +00:00 |
|