zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-06 12:01:40 +08:00
Code Issues Packages Projects Releases Wiki Activity
21,756 Commits 43 Branches 79 Tags
ddec15fe87f341fe3ee8b0da2ba120acbf36d668
Commit Graph
1515 Commits
Author SHA1 Message Date
Philip Pfaffe a7a01da4e1 Correctly declare all as a shorthand 
Fixed: 329821774
Change-Id: Ic880b097fcf6519cb11c23989223ef0019006173
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5783740
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-14 14:10:46 +00:00
Simon Zünd a92b0bba20 [deps] Use gclient sync --nohooks to fetch GCS node binary 
R=pfaffe@chromium.org

Bug: None
Change-Id: I100abf66fad16f3e4ba22c9bea04f564adcc2569
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5776285
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-09 12:56:26 +00:00
Kim-Anh Tran 847478ba87 [ve] Use absolute path to KnownContextValues.ts 
Bug: 357571602
Change-Id: Ie49541d953872ef32e90ce01e8d7b5f8d30f7035
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769261
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2024-08-07 17:10:01 +00:00
Adam Raine 17f93b862f [RPP Observations] Add detailed local/field comparison text to the tooltip 
https://screenshot.googleplex.com/4s5TLYGNk9rYC3p

Bug: 313906438
Change-Id: Iffc935e1c21d0ef1665ed4e8cdb718fb388d2456
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5767601
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-08-07 15:11:40 +00:00
Jack Franklin f554ff5322 RPP: insight hover icon design system fixes 
As a drive-by, also fix the lint rule to allow the sys elevation
variables when declaring box-shadow.

Bug: 348591291
Change-Id: Ib80460fef3ca4fc963e4142c2b88bfa164c8876d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769260
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-07 13:35:02 +00:00
Danil Somsikov 2c9421b8f3 Also add newline at the end of KnownContextValues.ts 
Bug: 357571602
Change-Id: I2e694ae18db30c0b0d83ab072807466e5f1324dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5769257
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-07 11:59:10 +00:00
Danil Somsikov 9ea056f21c Include the license header into the KnownContextValues.ts 
Bug: 357571602
Change-Id: Ib5a5ab044d49f255579ae0477987bf14f39819f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5766436
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2024-08-07 10:59:19 +00:00
Danil Somsikov 08ac97309f [ve] Track known jslog context values 
This CL introduces a list of known jslog context values, an eslint rule
to update this list and a console error message when unknown context
values are being used.

Bug: 357571602
Change-Id: I5cb2b2e8788537022d11a3acc61fb37a23bcd38d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756569
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2024-08-07 07:40:23 +00:00
Adam Raine 8a1160df26 [RPP Observations] Adhere to greenlines and update style 
Before:
https://screenshot.googleplex.com/6MXsxBbwXMAT8Mx

After:
https://screenshot.googleplex.com/3eirANU4yMuFYJ7

- Use headings and landmark regions as the mocks indicate
- Add accessible labels to controls as the mocks indicate
- Move combobox labels inside the outlined region
- Updates `ban_a_tags_in_lit_html` to allow `<aside>` tags
- Minor style updates

Bug: 334926021
Change-Id: I5b269e5c07c1a3c88ee5daebbc68c9c8f6a10949
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5762777
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-06 09:19:21 +00:00
Adam Raine 3442a3ef00 [RPP Observations] Add basic info nuggets to metric cards 
https://screenshot.googleplex.com/4Ctja2pv2iAsRWG

The code for the info nugget strings is auto-generated by a script. In
theory, we shouldn't need to run this script very often so not worth the
effort to add it to the formal build process IMO.

This required a pretty large refactor of the `MetricCard` component,
but it's a worthwhile cleanup.

Bug: 313906438
Change-Id: Ia6c7f84954ba71e358031f84f48eaaad22d69ee1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5757940
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-08-05 16:34:02 +00:00
Philip Pfaffe 3b208214f0 Make manage_node_deps script compatible with a chromium checkout 
Bug: none
Change-Id: I7fa46c6313d43a60ceea7564222a7b9d162ea584
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5752061
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-31 08:31:57 +00:00
Liviu Rau 75dccf1923 Update chromium_browser_protocol_revision only on actual rolls 
Bug: 352290454
Change-Id: I7161938a3482b4123fd7da67679270d321f6a501
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5737518
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Liviu Rau <liviurau@google.com>
 2024-07-24 13:30:09 +00:00
Philip Pfaffe 2e879471bc [build] add source urls to legacy CSS files 
This makes debugging devtools styles much easier.

Fixed: 353448941
Change-Id: Iaea08580f9ad563b40f99a7f34da23055b4c8551
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5712990
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-17 07:43:20 +00:00
Paul Irish fa68c093a2 Introduce eslint rule enforce optional properties are last 
Bug:338453175
Change-Id: I67b041f221592afd32f2409c228c4e5fdab1b9d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5704156
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-07-16 23:11:18 +00:00
Liviu Rau 88c99fa3e7 Keep track of the last time we rolled browser protocol 
Also added the option to write the 2 revision numbers to a file to be consumed by the builder for writing a gitiles log line(s) in the CL description.

Bug: 352290454
Change-Id: I6941c9121347ad11d86cc022d98b70852b4373ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688845
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-07-11 09:49:29 +00:00
Eric Leese 460be15667 Add support for running tests in a full checkout. 
Allows the npm run test script to work when running from the
third_party/devtools-frontend/src folder of a full chromium
checkout. In this case it will trigger a chrome build and use
that binary instead of a downloaded release.

Bug: None
Change-Id: Ib53ee477954f298f443b0f528c68b25293701338
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683365
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-07-10 12:52:54 +00:00
Philip Pfaffe 9d80aef256 [testing] Delete obsolete runners 
Fixed: 333423685
Change-Id: I5eb0ff36ee81fad3c50ba96b3a79d1f7296df5d3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5563425
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-09 18:09:36 +00:00
Liviu Rau 715da070da [testing] fix interaction tests coverage 
Bug: 333423685
Change-Id: Idfc1d058e4041afe4e53fc2aa63f877b9bbe27ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688550
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Liviu Rau <liviurau@google.com>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-09 14:01:56 +00:00
Liviu Rau 6153d30e73 Add revision info to README.chromium files in dependencies 
Bug: 349578038
Change-Id: I32059625a8efb04f339a052a2c6a30b7f1588981
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5672207
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-07-03 09:19:00 +00:00
Alex Rudenko 4c70dd1644 Remove TypeScript globals 
It looks like they all are part of TypeScript types now.

Bug: none
Change-Id: I517703732cf0ad88891981f7b9e402563dc6e47e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5643075
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-06-20 04:27:06 +00:00
Yuan Kang d60d33e9f3 Add NPM Lockfiles: 
Adds corresponding NPM lockfiles to package.json files. This enumerates dependencies, including transitive ones, and their versions, to avoid using vulnerable ones. For more details, see go/npm-lockfile-cl-guide

Bug: none
Change-Id: Ia1e5a33ef6adfe017b93e0fdb0265af04c22adfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5632127
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-06-19 04:40:09 +00:00
Changhao Han 2d4ded199d Remove - before dark theme class name 
It does not seem that we had a particular reason to name to dark theme
class with a prepending `-`. This CL removes it so that we're consistent
with general naming conventions for CSS classes.

Bug: None
Change-Id: I19665fee4cf7a1237134f30c8f1f41e5cce17ce9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5627213
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2024-06-13 13:37:31 +00:00
Alex Rudenko 1159f76477 Roll puppeteer to 22.11.0 manually 
Also, removed source map files from the automatically rolled
libraries to avoid hitting the limits on Windows.

Fixed: 346956226
Change-Id: Ic8a7e9d272c0fc018ec0a583e7fe9b08f4f71b8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5629080
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-06-13 12:52:21 +00:00
Liviu Rau bd81a0549d [browser_protocol] Use node from devtools 
Node deps got removed from chromium and the roller fails again.https://ci.chromium.org/ui/p/devtools-frontend/builders/ci-hp/Roll%20deps%20and%20chromium%20pin%20into%20devtools-frontend/b8746095888130672961/overview

Bug: 344827358
Change-Id: Ibd0fcdf756f9bf3a950cf841163a4a7f99ea45bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5594155
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-06-05 08:04:18 +00:00
Simon Zünd 7a3d427aa0 [unittest] Pass 'is_test_script=True' to the LPAC ACL script 
We don't know if this will actually fix the problem but it doesn't
hurt to try.

R=pfaffe@chromium.org

Bug: 324929074
Change-Id: I7c92bc036863b93f4f90af5be147e67f88a52115
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5568340
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-05-28 08:06:56 +00:00
Jack Franklin 2bbb561a5b Update metrics enum PRESUBMIT check with right path 
The enums file has been moved in Chromium.

Bug: none
Change-Id: I63bd0699076defabdbf13c2dbb58f47d496b7414
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5554256
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-05-22 11:32:21 +00:00
Liviu Rau 3b182cbdd8 [browser_protocol] Remove dependency from roll script 
It got removed from Chromium and the roll script fails now because of it. It also failed without this dependency in the past when we had to add it. We will probably need to pick it from somewhere else if it is still needed.

Bug: 340813542
Change-Id: If33364a9ec34220afb210ea02c02e683930cb0b5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5545190
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-05-21 19:41:50 +00:00
Philip Pfaffe 4f909f3180 [testing] Set chrome binary acls on windows 
Unittests on windows occasionally fail because the chrome binary acls
aren't set up correctly.

Bug: 333423685
Change-Id: If6620bd162e434ee42e5d2ccee657c5b318bdf35
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5553714
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-05-21 10:27:39 +00:00
Liviu Rau cc4ed1e43f Reland "Resolve compilation target in server.js from the current path" 
This is a reland of commit cbda0e2158

Proof of fix @ https://chromium-swarm.appspot.com/task?d=true&id=696bff6c916ca010 where we trigger the same swarming task with a different CAS hash (one generated by the windows bot on self cq).

Original change's description:
> Resolve compilation target in server.js from the current path
>
> Bug: 333423685
> Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
> Reviewed-by: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@google.com>

Bug: 333423685
Change-Id: I7ae05df1492a392e85e13627edf70422fc9abdd0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5521433
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-05-07 14:16:44 +00:00
Kim-Anh Tran 22d4b16e61 Revert "Resolve compilation target in server.js from the current path" 
This reverts commit cbda0e2158.

Reason for revert: Causing problems on the windows bot leading to an unmatched backspace, see example: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Win/12263/overview


Original change's description:
> Resolve compilation target in server.js from the current path
>
> Bug: 333423685
> Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
> Reviewed-by: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@google.com>

Bug: 333423685
Change-Id: Ib66128b8d0380ead11ec6220947d56b28154d69a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518716
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Owners-Override: Kim-Anh Tran <kimanh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2024-05-07 07:32:55 +00:00
Liviu Rau cbda0e2158 Resolve compilation target in server.js from the current path 
Bug: 333423685
Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-05-06 13:00:39 +00:00
Philip Pfaffe d522f860b0 [cxx] Use new test driver infrastructure for the cxx debugging extension 
This lets us remove a test runner.

Drive-by: Remove goma-related flags.

Bug: b:333423685
Change-Id: I104113dc3b49ab34e13c8abe83d9c2994345c04e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5465640
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2024-04-18 14:20:44 +00:00
Philip Pfaffe 52096b92dc [testing] Run ninja in run_on_target if the script does not exist 
This simplifies bootstrapping scripts that themselves run autoninja, but
can only do so if they were compiled before.

Bug: b:333423685
Change-Id: If3689ec50e5e0e256d16f942a8017685789bdcca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5454292
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-04-17 10:15:30 +00:00
Alex Rudenko 2e1b8abf93 Simplify manage_node_deps.py 
This CL simplifies manage node deps.py by
moving preferences to npmrc and removing
custom command support that is not documented.

Bug: none
Change-Id: I155fb8ca84deea883a03175f2bc6000cd6a9ad14
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5458177
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-04-17 07:32:39 +00:00
Philip Pfaffe 7d540a0ec9 [testing] Do not rely on test runner config in sources-helpers 
Drive-by: disable --help and --version in run_on_target

Bug: b:333423685
Change-Id: If48c71b9378c5d60229fdfccaa4775a0a11b09a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5454271
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-04-16 05:18:32 +00:00
Philip Pfaffe 705cfde469 [testing] Run interactions tests with a unified test runner 
Bug: b:333423685
Change-Id: Ibbde7fe953dbcd1350c8fe3011d43063ea69c1d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5435762
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-04-11 10:29:41 +00:00
Philip Pfaffe ce5afc0d07 [testing] Use fixed paths to refer to snapshots/screenshots 
This avoid special casing and passing golden locations around. In order to nicely reference snapshots, we move them next to the test files since snapshots are looked up by test name anyways.

Bug: b:333423685
Change-Id: I02188633f25dffe8f863d64b1e769cbb5563b2b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5435761
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-04-10 13:49:46 +00:00
Alex Rudenko 7042abca0b Update mocha to 9.2.2 
- fixes a vulnerable dependency
- sorts devDependencies in asc order (done by npm)
- manage_node_deps should --save-exact version by default

Fixed: 333413840
Change-Id: Iaa670259db9771dab89c72214c17d0420e02eaa3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5439476
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-04-10 05:58:47 +00:00
Paul Irish a4fc921e3d Watch build: Compile node test files as CJS 
node_ts_library outputs CJS, and is used by all .ts files within test/
This CL allows watch_build to correctly build them.

In the future, we could use `gn desc` to resolve these conditionals for
us. Alternatively, we could just improve the speed of regular
incremental builds.

Bug:none
Change-Id: I1111e13368beb38c80d1b25091c98ec47b685fae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5403346
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-04-09 04:42:36 +00:00
Alex Rudenko 2e05f8f1b9 Move devDependencies to package.json 
it gives the following benefits:

- go/sk-npm-audit-mirror can perform periodic audits for repo
and auto-file bugs.
- Dev dependencies are declared in a typical location for npm projects.
- allows simplifying manage_node_deps.py the installation by running one `npm install` instead of installing packages one by one.

Bug: chromium:331331303
Change-Id: I7a5486acb89e174be5277c7696cb287a668d2ed7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5423233
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-04-05 06:22:21 +00:00
Jiacheng Guo c3f4bcd032 EarlyHints: Show early hints headers in the request headers 
The CL handles the optional early hints headers from the browser and
shows them in the request headers panel.

DISABLE_THIRD_PARTY_CHECK=Update protocol

Bug: 40222701
Change-Id: I79ce7441a48f23d41cdaf22b0d62cb9ecb36477a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5367623
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Jiacheng Guo <gjc@google.com>
 2024-04-05 06:19:12 +00:00
Benedikt Meurer 4941b552a9 [cleanup] Move separated UI utils back into UIUtils.ts. 
During the ESM migration, some UI utils were moved out of UIUtils.ts (as
part of https://crrev.com/c/1967134), but there's no advantage/reason
for why this is beneficial. And now it's blocking the removal of the
`__widget` and `__widgetCounter` properties, because some of the
separated UI utils implicitly depend on Widget.ts, but without properly
importing anything from Widget.ts, and they get away with it because of
the use of `any`.

Bug: 332815658
Change-Id: I52742d10d6b0e4aba02b6a055b5c55c51c920023
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5419445
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-04-04 09:26:48 +00:00
Kateryna Prokopenko b63b015fbd Add part of Material design tokens 
Bug:none
Change-Id: Iebf1a6a5190df67bea3c3dbda25c28718a111510
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5366404
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-03-18 14:44:21 +00:00
Simon Zünd 8a6fb2f6f5 [unittest] Also set LPAC ACLs on win when running unit tests 
The CL https://crrev.com/c/5330806 sets the ACL when downloading the
CfT binary during "gclient sync". This is not sufficient for our
CI bots as the unit test suite is run on swarming where the relevant
files are just copied over.

To fix these sporadic failures we'll also set the ACL on windows
as part of `run_unittests.py`.

R=pfaffe@chromium.org

No-Tree-Checks: true
Bug: 324929074
Change-Id: I200b78a2ed1f31ffa24a696266e508a4deabc808
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5371760
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-03-14 09:26:31 +00:00
Simon Zünd 5c0e0d8abb [deps] Upgrade TypeScript from 5.2.2 to 5.4.2 
DISABLE_THIRD_PARTY_CHECK=Requires fixing up front_end files
R=alexrudenko@chromium.org

Bug: None
Change-Id: If7cd9777abc1daf8af48cf006576e39d5d57ce94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5365623
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-03-12 12:35:14 +00:00
Eric Leese 5377e0bbb2 Don't print screenshots to console, fix retry hook 
This makes several improvements to test output:
 - Screenshots are no longer printed to console or saved to
   an html file. This is unnecessary now that they are uploaded
   to rdb.
 - When a test is retried, the timeout hook was not correctly
   hooked, which produced unexpected errors from multiple done
   calls. This has been fixed.
 - Screenshot error message now includes causes, which displays
   the pending async stacks on timeout.
 - Driveby fix to improper assertion in console-helpers.

Bug: None
Change-Id: Ia76f88ad9fbf1236a47a1f27eff41ee93d1a28a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5349145
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-03-07 09:58:52 +00:00
Alex Rudenko 19c832a558 Fix tooling to pick up transitive dependencies 
Bug: none
Change-Id: Ifc98fc5a9e40c2090f497e856bf978d76f93fb53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5349136
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-03-06 13:05:13 +00:00
Danil Somsikov 45f6ad10a0 [ve] Use button element instead of span to handle keyboard automatically 
Bug: chromium:1467464
Change-Id: Icd8657299d87c0f4cc6c0f08123a4103975399b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5339956
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-03-06 07:08:18 +00:00
Paul Irish 73829c78c0 [Watch] Support multiple simultaneous file changes 
If you change multiple files at once (git checkout, git restore, etc),
the current watch_build only recompiles the first. This CL introduces
debouncing to collect all changed files.

Also, if a ninja rebuild is needed, now we skip over the TS/CSS
rebuilds.

Bug:none
Change-Id: Ic9df97ca5c286453480c057a232720c0fc866630
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5337249
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2024-03-04 10:17:16 +00:00
Simon Zünd d03865b108 Revert "Add @webgpu/types" 
This reverts commit 067c706e79.

Reason for revert: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5076956
is abandoned

DISABLE_THIRD_PARTY_CHECK=Has ts_library.py change

Original change's description:
> Add @webgpu/types
>
> DISABLE_THIRD_PARTY_CHECK=Add @webgpu/types
> No-Presubmit: true
> Bug: 1506431
> Change-Id: I06f8d3758110f19298965e84e15f33c02bf4fbda
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5081999
> Commit-Queue: Fr <beaufort.francois@gmail.com>
> Reviewed-by: Simon Zünd <szuend@chromium.org>

No-Presubmit: true
Bug: 1506431
Change-Id: Id19766f75d97b8339058fb51693747a47a4b6312
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5335357
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-03-04 08:12:37 +00:00