zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,631 Commits 45 Branches 79 Tags
e343bdfafbbee2aac647db0915cb766dcaf04122
Commit Graph
16 Commits
Author SHA1 Message Date
Tim van der Lippe e343bdfafb Migrate to private class fields in entrypoints/ 
R=szuend@chromium.org

Bug: 1222126
Change-Id: I6863d8180c6a44a0e607e860bbce89bf9d3642ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3338351
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2021-12-15 11:49:27 +00:00
Tim van der Lippe d3b32d536c Cleanup entrypoint initilization 
The `appStarted` callback was used to signal `MainImpl` that the Runtime
had finished loading all modules. However, since we no longer have any
such modules, we can remove this callback altogether and cleanup the
instantiation of each entrypoint a bit, reducing the amount of
side-effects that we have.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iacee65e6ce00ce6134756b4c77ffb24731e42745
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313061
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 13:50:13 +00:00
Tim van der Lippe 339872c26f Remove modules support from Runtime 
All of these fields/functions were related to loading the legacy modules
powered by the now-removed `module.json` files. Therefore, we can clean
all of this up, as they are all unused.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iebe807a91415d16ba653a32abe4cd237d5b60bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313060
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-02 13:27:53 +00:00
Tim van der Lippe 67872d6878 Remove entrypoints/node_app/node_app.json 
This CL does a couple of things to preserve the current behavior:
- It folds `node_main` into `node_app`, since we no longer require that
distinction (this was only required prior where we used `autostart` for
`node_main`, which we no longer do)
- It removes as much side-effect instantiation from various modules and
moves them into `node_app.ts`. The order is a bit awkward, but the calls
at the end of `node_app.ts` is the order of side-effect calls as it
exists currently. After we cleaned up all entrypoints, we can remove
some of the calls and clean it up further, but let's keep them here
explicitly to ensure we retain existing behavior.
- Folds `node_app-meta.ts` into `node_app.ts` for simplicity
- We now roll up everything into `node_app.ts` directly, rather than
having a separate meta script. Since this is an entrypoint, we can do
that here. Since the entrypoint will always eagerly load, we don't need
an explicit difference between the meta file and the module
implementation.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ida1cee76ae04b3d590dcd16d0225f65852bce5a5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306499
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-30 14:32:54 +00:00
Tim van der Lippe 33d37636a0 Move main side-effect instantiation to entrypoints 
To ease the migration off the `.json` files, we first need to move the
main instantiation to the correct timing. If we perform it too early,
runnables that we register later don't work (which we are going to do in
a follow-up CL). However, side-effect instantiation is obscure anyways,
so let's move them into the appropriate entrypoints so that we make this
explicit.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I5686c446a371f0fc0bb4e784c705775973530f4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306498
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 16:31:06 +00:00
Tim van der Lippe 19b714a693 Remove entrypoints/shell/shell.json 
Shell no longer has any content, so we can remove it from all
entrypoints. We still want to share the contents of the meta files and
all, so keep these in. However, since we are no longer processing the
`shell.js` file `build_release_applications`, we can now fold in
`shell-meta-files.ts` into `shell.js`.

Ideally, we also change `shell` to be TypeScript-authored, but we can
only do that after all entrypoints that import it (in their respective
`.js` files) are TypeScript. So we will have to do that last.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I47239286f6f1dbff63ce69cf8ca4c78bd4761030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3306497
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-29 15:55:52 +00:00
Tim van der Lippe 379c288384 Allow meta-files to import relative entrypoints 
We previously disabled this rule in a lot of places to workaround the
fact that the rule wasn't adhering to importing entrypoints in meta
files. Instead, let's update the rule to make it clear that this pattern
is expected and fine.

R=alexrudenko@chromium.org

Bug: 1271490
Change-Id: Idd139b42d9bb27f1f20e573b31bcd5efff8815af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3289221
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-18 14:53:06 +00:00
Tim van der Lippe 28de514742 Remove panels/js_profiler/module.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iea3238e8ce6395eb781a99acb2b59864ff69ded6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282588
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-17 14:57:23 +00:00
Tim van der Lippe 88e4510167 Fix node app 
Upon startup, the `node_main` module has side-effect class instantiation
to bootstrap the panel. By removing the module.json file, we also
removed the side-effect instantiation that `startApplication` otherwise
would have done.

Therefore, explicitly add back the side-effect import to start the
application properly.

R=yangguo@chromium.org

Fixed: 1266458
Change-Id: Id92a8b80cfb169cd7ab15b3e4a850304344c8dc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259471
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2021-11-03 16:55:27 +00:00
Tim van der Lippe 067a9d95d1 Remove entrypoints/node_main/module.json 
R=szuend@chromium.org

Bug: 1127902
Change-Id: I01c222ca7829254d8f4ff16d178f787ff7ccd29d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3252968
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-10-29 12:32:22 +00:00
Tim van der Lippe 6892da0014 Add GN visibility to entrypoints 
R=jacktfranklin@chromium.org

Bug: 1202788
Change-Id: I5ff52856d177529c26655e79f1fa5db96fa06196
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2856775
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-29 08:54:21 +00:00
Tim van der Lippe cc6e7523bd Move node_main to entrypoints/node_main 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I26a1db130ebb61b2c5b98a72f28116d4ed17cc88
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2843314
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-21 13:52:35 +00:00
Tim van der Lippe c26c9ef40b Fold node_debugger into entrypoints/node_app 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I0b397dfa7ea26083fe0d773fb5c8f33a8b34e330
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831985
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-20 15:05:45 +00:00
Tim van der Lippe 28264f76dc Move js_profiler to panels/js_profiler 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: Icf072fcd7c6c9840deafae3213defc09890b99a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2831974
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-19 13:48:29 +00:00
Tim van der Lippe dbb97be22a Move startup to entrypoints/startup 
R=aerotwist@chromium.org

Bug: 1187573
Change-Id: If71a7d4eeda376e240fe7b1e12f94c853b3cba53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2828129
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-15 16:45:15 +00:00
Tim van der Lippe 7b347ca16f Move entrypoints to sub-folder 
All JavaScript files for each entrypoint are put in their respective
sub-folder of front-end. The HTML files load from the new location and
build_release_applications has been updated to load from the correct
location.

R=aerotwist@chromium.org

Bug: 1187573
Change-Id: I4b93f3a2127ef2d3ce7dccefe03f70e79dac1c19
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2818379
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-12 12:04:18 +00:00