 Kham Udom
|
e991071f67
|
High contrast work on Sources debugger panel
The changes fixes the hover and and keyboard focus on the panel. The
header gets a focus ring and when hovering or focusing the content
item, the background and foreground changes.
Before: https://imgur.com/a/gZD8xLg
After: https://imgur.com/a/LVruJ6P
Bug: 1048378
Change-Id: If697639f8a5b7d73844e1aab63c9bb2db884b295
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055546
Commit-Queue: Kham Udom <khamu@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
|
2020-02-14 16:06:43 +00:00 |
|
|
Jack Lynch
|
6790102aae
|
Make javascript breakpoints accessible
This change makes the javascript breakpoints pane accessible by:
- adding an option to the context menu to reveal the location of a
breakpoint for keyboard users
- allowing keyboard users to navigate the breakpoints list with the
arrow keys by refactoring the pane to use UI.ListControl, in response to
feedback on [1]
- putting the checked/unchecked status of a breakpoint and whether it
has been hit in its aria-describedby
These changes break a few web tests, so [2] must be merged first to
disable them. Test fixes are here [3].
Screenshots:
Context menu: https://gyazo.com/3f54dd9a1fd146270a64afd635cf2bc6
Hit breakpoint: https://gyazo.com/8363b986f36f67a213170dad73ba0450
Keyboard navigation video: https://i.imgur.com/ZOvVrxf.mp4
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1644461/14/third_party/blink/renderer/devtools/front_end/browser_debugger/DOMBreakpointsSidebarPane.js#141
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1894751
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1636716
Bug: 963183
Change-Id: I360c828145806a1133937ce8c6f2e4885cb0f900
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
|
2020-01-07 20:56:48 +00:00 |
|
|
Jack Lynch
|
f85ad68a1c
|
DevTools: Higher-contrast UI for hit breakpoints
This change adds a border to the right side of list elements for
breakpoints that have been hit, making it easier to distinguish hit
breakpoints. Initially recommended by aboxhall in
https://chromium-review.googlesource.com/c/chromium/src/+/1629013/39#message-e4f3d258e8c2e46652d76de2c675361f23afe9ca
Before: https://gyazo.com/f5df60f6de04c79cf3daea6b1947d9b3
After: https://gyazo.com/1e743392451a4eb0f2aba9d22d2b7253
https://gyazo.com/69ace940f429762e46cb70fca7c8774c
Bug: 963183
Change-Id: I336d47902790e16cdff0c3f6c1317ba366f95321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717269
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#687830}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4c720ea1311597ef036326162ffcc6a39a5dbaf9
|
2019-08-16 21:25:21 +00:00 |
|
|
Erik Luo
|
6282eab176
|
[DevTools] add margins to align breakpoints, search results
Screenshot: https://imgur.com/a/YlClsZ0
Bug: none
Change-Id: Ic6732ba029cb0c03a166db77b32daf31f3b79cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1290199
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601027}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0e20502b913accb893935890eb5db0139b7b417
|
2018-10-19 02:16:38 +00:00 |
|
|
Blink Reformat
|
4c46d0969f
|
The Great Blink mv for source files, part 2.
Move and rename files.
NOAUTOREVERT=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 768828
TBR=darin@chromium.org
NOTRY=true
Change-Id: I66d3b155808bc5bdbf237b80208e1e552bcf7f28
Reviewed-on: https://chromium-review.googlesource.com/1001153
Reviewed-by: Blink Reformat <blink-reformat@chromium.org>
Commit-Queue: Blink Reformat <blink-reformat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549061}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0aee4434a4dba42a42abaea9bfbc0cd196a63bc1
|
2018-04-07 15:32:37 +00:00 |
|