zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity
23,936 Commits 43 Branches 79 Tags
ec4c0fcc2016b3bb25222ddd35dc337f56ea50a3
Commit Graph
1602 Commits
Author SHA1 Message Date
Jack Franklin 8996ce6060 Lint: add test case for double slash in import path 
Accidentally importing something as `foo//bar.js` (rather than
`foo/bar.js`) should not matter, and indeed both the TS build and
ESBuild compile fine. However you get an error when running DevTools at
runtime. What's unfortunate is that the error is very non obvious and it
took me ages to realise that the root of it was an accidental `//`.

This CL adds a check for this to the existing import rule and a test.

Fixed: 346966388
Change-Id: I3922a58b89ce639fc619c0e2b83cd14f3fe993cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6157259
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2025-01-08 07:00:08 -08:00
Nikolay Vitkov 1f49d6a42b [tools] Fix test for EsLint and Stylelint 
After the latest update to the deps these test started failing.

Bug: none
Change-Id: Ifd4a4099e465aa61087675f2fb564272e277ced0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6148217
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-08 01:56:59 -08:00
Nikolay Vitkov 9554d8f023 Unify code in check_experiment 
Use the same setting we use in EsLint for consistency.

Bug: none
Change-Id: Ic56b3bb5bc85fbf37925423130e8dbb3d1ce11df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6148455
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-08 01:43:11 -08:00
Benedikt Meurer 39e5133b95 [test] Introduce Platform.DevToolsPath.urlString helper. 
This adds a helper function to avoid sprinkling casts to
`Platform.DevToolsPath.UrlString` all over our unit test
suite, combined with an ESLint rule to enforce that we
use this helper consistently.

This leads to much more readable test code for unit tests
that are concerned with APIs that take `UrlString`s, and
the code is more consistent.

Bug: 323797639
Change-Id: I6d797c0db9e5bd2fd019b83b9a7a269c7437ebdf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6148578
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2025-01-07 05:49:23 -08:00
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9 
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-07 05:41:31 -08:00
Nikolay Vitkov 2a1b3b34b1 Update StyleLint to v16 
Stylelint v16 deprecated CJS so I moved our lint script to ESM,
and fixed all the deprecation warning.
The only place I needed to silence them were tests,
as we import CJS there.

Bug: none
Change-Id: Iae4d2df76c855a9738b774a2d035f22509770215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6138610
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 02:57:06 -08:00
Nikolay Vitkov 924fc2c153 [deps] Update StyleLint to v15.11 
Info at https://stylelint.io/migration-guide/to-15
Our custom rule needed to be updated to reflect a small change.
All changes are separated into patches for ease of review.
More work is need for a v16 migration so separating it to reduce
risks of breaking.

Bug: none
Change-Id: I616829fba25b06bf8febe8390074046ad582f531
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6126881
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 01:57:35 -08:00
Benedikt Meurer 22a077e79e [eslint] Remove unused static-tag-must-be-static-property rule. 
Bug: 370734442
Change-Id: I88925be37d6217f01764c02a6119ac6b30acb2a8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6126882
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-02 05:39:55 -08:00
Nikolay Vitkov 55adf677d3 [eslint] Migrate to Flat config 
A necessary step to adopt EsLint v9.
More can be read at - https://eslint.org/blog/2022/08/new-config-system-part-2/
In short - only a single configuration is used a cross the whole repo.

Bug: none
Change-Id: I74cd613fba25b94cee92e4b7c1b525471bcbe44b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6059264
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 04:58:36 -08:00
Nikolay Vitkov 04cca9f499 [cleanup] Remove dead code 
Reland of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376

Now that devtools-frontend is merged directly into chromium,
we can safely remove this.

Bug: none
Change-Id: I882e3f58a71eab50485eb0ef23b398154d784531
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110744
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 04:29:39 -08:00
Benedikt Meurer 8fbdd974ef [eslint] Add no-customized-builtin-elements rule. 
Introduce an ESLint rule to disallow customized built-in elements from
being introduced, since these don't work (at all) in Safari and aren't
compatible with the Vision for the Chrome DevTools UI Engineering[^1].

[^1]: http://go/chrome-devtools:ui-engineering-proposal

Fixed: 386453980
Change-Id: I16b61f8209d2d5094bb0d6e81fba9cae7f2d9687
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6113688
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 13:31:48 -08:00
Benedikt Meurer e6282b1769 [eslint] Prefer assert.instanceOf and assert.notInstanceOf. 
This is both more readable and generates a more meaningful error message
when the assertion fails.

Bug: 386335487
Change-Id: Ib41beec5951c3e38dfad1503e4f368dcc7aabfbb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110490
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 06:31:52 -08:00
Benedikt Meurer 7b03afad22 [eslint] Comparisons with object and array literals must be deep. 
The previous check was too restricted in that it only checked for
array literals, and didn't bother also checking for object literals.
It was also not restricted to just the `assert.strictEqual` and the
`assert.notStrictEqual` methods, and unnecessarily prevented us from
using for example `assert.hasAnyKeys` or `assert.sameMembers`, which
is clearly beneficial in various cases.

This new check also provides a fix.

Bug: 40185458
Change-Id: I1b151cf8eb594b7255c77380967aea39a46ee2cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110248
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
 2024-12-30 03:24:19 -08:00
Benedikt Meurer 6fed9bc827 [eslint] Remove obsolete migrate-* rules. 
These were temporarily used to migrate the style sheet approach, and
are no longer required.

Bug: 40140559
Change-Id: If2da715009576897f6f5ed343856138369d17eb6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6113683
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 03:15:34 -08:00
Benedikt Meurer a74dbac647 [eslint] Auto-fix support for prefer-readonly-keyword rule. 
Bug: 40158772
Change-Id: I4d28d3c7a324783e96500499d676b9715018cc20
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110406
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 03:15:34 -08:00
Benedikt Meurer b434f78c13 [cleanup] Remove obsolete lit-no-style-interpolation rule. 
This ESLint rule has been ineffective for almost 4 years now, since the
introduction of the no-style-tags-in-lit-html ESLint rule, which
disallows any `<style>` tags within lit-html templates altogether.

Bug: 40140559
Change-Id: If9dc3bdc3d803745ba2a4a1d2f9f977ed065ba80
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110229
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 02:07:46 -08:00
Benedikt Meurer 3832e30baf [cleanup] Remove obsolete no-repeated-tests ESLint rule. 
The custom `repeat()` method was removed in https://crrev.com/c/5804334,
so there's no need to keep this ESLint rule - whose only purpose was to
check that no one accidentally commits an `it.repeat()` call in E2E
tests.

Bug: 40138497
Change-Id: If42e4d2683b81393d143a14f29edab51cd565a85
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6120410
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 02:06:41 -08:00
Benedikt Meurer fb31435bfb Consistently prefer assert.isOk and assert.isNotOk. 
`assert.ok` is an alias for `assert.isOk`, and similarly `assert.notOk`
is an alias for `assert.isNotOk`. For consistency with other assertions
such as `assert.isNull` and `assert.isNotNull`, we enforce the use of
the slightly longer form here as well.

Bug: 386335487
Change-Id: If845a5675a78598d01b30532985239f74f701db7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6120409
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
 2024-12-30 00:33:56 -08:00
Benedikt Meurer 5cb9f987f7 Disallow equality assertions with boolean, null, and undefined. 
Require the more descriptive `assert.isTrue`, `assert.isFalse`,
`assert.isNull`, `assert.isUndefined`, and friends instead, which also
produce a more meaningful error message than the generic
`assert.strictEqual`, `assert.deepEqual`, and friends.

Bug: 386335487
Change-Id: Ic58a07381196c358a43857b53364d74076e9c7e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6113833
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-30 00:32:53 -08:00
Benedikt Meurer e5afea232d Consistently prefer assert.lengthOf to check array-like lengths. 
In our tests, we should stick to ideally just one way of asserting
array-like lengths, `assert.lengthOf`, and avoid any kind of
combinations `assert.equal`,`assert.strictEqual`, `assert.deepEqual`,
or `assert.deepStrictEqual`.

Bug: 386335487
Change-Id: I8f88e214acdae0c6e34dbb169c62ebc9a80317af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6113832
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-30 00:31:50 -08:00
Benedikt Meurer 3dffd37833 Consistently use assert.deepEqual instead of assert.deepStrictEqual. 
Previously we have been a bit sloppy with sometimes using one or the
other. In Chai both methods perform exactly the same comparison, but
the name `deepStrictEqual` can be a bit confusing to developers not
familiar with the Chai implementation, and particularly might leave
you wondering what exactly is *strict* about this method.

Fixed: 386330115
Change-Id: Idda55ee784b01cce650996ab3d56f76e220e6b2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110227
Commit-Queue: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Samiya Caur <samiyac@chromium.org>
 2024-12-27 04:38:55 -08:00
Benedikt Meurer 586a9a5908 [eslint] Adopt ESLint Rule Naming Conventions. 
Update our custom ESLint rules to follow the official naming
conventions[^1], in particular the rule names need to

1. consistently use dashes to separate words (rather a mix of
   underscores and dashes), and
1. consistently use `no-` prefix for rules that disallow something.

Drive-by-fix: Also remove the `fixable` setting from rules that don't
provide a fix.

This is a functionally neutral change.

[^1]: https://eslint.org/docs/latest/contribute/core-rules#rule-naming-conventions

Fixed: 386319581
Change-Id: Ifcb6c0e4ca8334a263be6534596c30b3bcca243b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110726
Reviewed-by: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-27 02:54:56 -08:00
Jack Franklin 4a23e068bd Add some types to AI Assistance script 
I was making them to aid my debugging as I was getting familiar with the
code, and thought we might as well land some to help others too.

Bug: 704639063
Change-Id: Ia4678cc136e6414438d19c7652fd9f5b390c0cae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6085698
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-12-11 11:32:14 +00:00
Jayson Chen 2e999d1495 Add wicg scheduling API definition 
window.scheduler.postTask and .yield are originally not available in the devtools-frontend codebase. This CL added the type definition so Typescript recognizes the API

Bug: 383240467
Change-Id: I4a395aca4e3956ceaa08053dcded5017f0ed10b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6081857
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-12-10 20:09:10 +00:00
Adam Raine 61007ff654 [RPP Observations] Update definition of "field data" in translation contexts 
Bug: None
Change-Id: I6f3cf66452585df8d909ac3c38a5592638ebcb4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6079049
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
 2024-12-10 15:56:53 +00:00
Alex Rudenko 786bd42909 [AI Assistance] Renames and refactorings 
Fixed: 380044548
Change-Id: I0c71417a8189a728ff10e9b6504a9887e3f26652
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6080811
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-12-10 11:47:32 +00:00
Alex Rudenko 789751e321 Revert "[cleanup] Remove dead code" 
This reverts commit 26bc275ce1.

Reason for revert: used in devtools-internal so breaks the roll

Original change's description:
> [cleanup] Remove dead code
>
> The infra now all uses `npm run lint` for linting.
> Moves a common function to the only place it's used.
>
> Bug: none
> Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

Bug: none
Change-Id: I090c1750ec1ada53df22c443253922162f41e271
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6072803
Reviewed-by: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-12-05 07:06:18 +00:00
Nikolay Vitkov 26bc275ce1 [cleanup] Remove dead code 
The infra now all uses `npm run lint` for linting.
Moves a common function to the only place it's used.

Bug: none
Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-04 15:44:37 +00:00
Ergun Erdogmus a416dab924 [FreestylerEval] Use current_message for request input 
After changing the request shape we send, we needed to update
eval UI to use the new structure.

Bug: none
Change-Id: Ie19fa03d9ec521a36de18cfb1643c0b8166bf27e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063637
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-12-03 16:19:43 +00:00
Nikolay Vitkov 8962d5956d Fix check_experiments.js import 
After the @typescript/eslint update their resolution does not include
CJS so the import fails. The files are still have CJS support
so import the file directly.

Bug: none
Change-Id: I84ad3164fc1046b616d99fe0c196f93f2523fcfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6059977
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-11-29 15:53:12 +00:00
Liviu Rau bec18e2c02 Replace deprecated gsutil cli with gcloud storage 
Bug: 380123202
Change-Id: I4d957387c063b57b635f1e6f9ad36dd2304cca5f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038616
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
 2024-11-21 12:28:54 +00:00
Alex Rudenko bf9bcbf328 A helper script to convert to tsv 
Bug: 379059135
Change-Id: I555f763d2123f1cb1b39fd3ae9468bb0f69613f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038154
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-21 12:27:51 +00:00
Alex Rudenko 16f5a6c244 [FreestylerEval] test using UI 
We now know that the hanging issue was due to code generated by the
LLM hanging and therefore the workaround to use a special event
was not actually helping.

Bug: 362730981
Change-Id: I4f70eae7aec05812922ba1035eb8a14bf831abfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5832744
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-11-20 19:19:03 +00:00
Dirk Pranke a2674c024e Fix Python SyntaxWarning in //scripts/build/wasm-as.py. 
In Python 3.12, unrecognized escape character sequences in a string
produce a "SyntaxWarning" log message when the file is parsed. The
fix is (usually) to change the string from a regular string to a raw
string, by putting an "r" in front of the leading quote.

Bug: 376746798
Change-Id: Ie888a8de6ae42c4daae6fa5028134722634d70c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5981155
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
 2024-11-13 17:20:36 +00:00
Eric Leese 983e380a4e Remove documentation of fictional describe.skipOnPlatforms 
Bug: None
Change-Id: I1ce59f5aa9c3f99a7be0e6b4c114df5b6e7fe0ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6004728
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-08 11:23:16 +00:00
Simon Zünd abf0cd1847 [deps] Update rollup to 4.24.3 (and update plugins) 
Since we have the major version jump, we needed to update quite
a few things to make this work:

  1. rollup4 ships with native binaries. We can't check them into
     our node_modules for all platforms. Luckily they also ship a
     a wasm version. This requires us to adjust the 'binary' path
     to `node_modules/@rollup/wasm-node/dist/bin/rollup` instead.

  2. rollup4 is more strict when it comes to ES modules vs
     CommonJS. We adjust this by renaming the rollup config files.

  3. Some plugins got deprecated so we had to replace them with
     the newer versions (source maps and terser).

Bug: None
Change-Id: If13d590c8185db6ad85b3992d0a869111909dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999255
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-07 05:25:54 +00:00
Nikolay Vitkov cd5440fbdc [lint] Fix Stylelint not running 
Node syncSpawn can be promisified, and never runs the following
scripts, but it somehow closes the process afterwards.
Marking no presubmit as it fails on windows if you change lint rules

No-Presubmit: true
Bug: none
Change-Id: I08fdc3174fe542a5f824239b085d3433e5a24573
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999261
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-11-06 15:43:19 +00:00
Liviu Rau 1c8dc082a7 Update builder name prefix for screenshot collectors 
Bug: 376446538
Change-Id: I64d31b001f74e74950bdd0bfc5e4be72e7d5a83d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5986493
Auto-Submit: Liviu Rau <liviurau@google.com>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alexander Schulze <alexschulze@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2024-11-04 11:24:16 +00:00
Simon Zünd 235aa05d64 [build] Fix esbuild bundling on windows 
R=kprokopenko@chromium.org

Bug: None
Change-Id: I19a809628072e94d96a35d04ec8615412b5b68ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5961818
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-24 09:52:50 +00:00
Benedikt Meurer 0d4dbaeca9 [lint] Read lit-analyzer options from toplevel tsconfig.json. 
This way the config is in a central place and can be reused for
ts-lit-plugin.

Bug: 375149136
Change-Id: Ic3805b059b5c9b0d103a152e1ff36b3c9c5245b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953717
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-10-23 14:10:30 +00:00
Benedikt Meurer a75ec1d5d6 [cleanup] Remove rules/lit_html_data_as_type ESLint rule. 
Bug: 375114000
Change-Id: I73e1f7b44733cbd98ad4565dc8e68a88596a3e0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953150
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-10-23 12:23:29 +00:00
Jack Franklin dd7b7212cf Lint itScreenshot.skip like we lint other skip calls 
Fixed: 373791684
Change-Id: If9729360cf7260b9cbf068b9cfa5f6876a60cada
No-Presubmit: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5933853
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-16 10:09:51 +00:00
Nikolay Vitkov 60a23c771c [Lint] Fix issue with window 
Windows max line argument is around 8000, if you pass that the command
will fail, we need to split the LitAnalyzer files when we spawn it.

No-Presubmit: true
Bug: none
Change-Id: I68dd71228b02a8ae01555b23a229f5fcc69b2a11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5923563
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2024-10-15 11:11:02 +00:00
Danil Somsikov 6806877859 Use type-only import where possible. 
Not only this is shorter, it also allows having a side-effect import in addition to the type-only
import and is properly understood by lit-analyzer.

No-Presubmit: true
Bug: 370734442
Change-Id: I32f0a6198e8de8175201d8ce576a63a9ce25806f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921081
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
 2024-10-11 20:29:33 +00:00
Joshua Thomas e2625e34dc Fix node path for arm macs 
Bug: 370734442
Change-Id: Ia3a0f63970e302a735b507467e843846a2159f98
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920518
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
 2024-10-10 17:33:29 +00:00
Nikolay Vitkov a4e79c12f1 Add fixer for assert equal rule 
We currently only report an error, but we can auto fix in the
general use cases where we can deduce the expected type.

No-Presubmit: true
Bug: none
Change-Id: Icb0b8857664f94da6a2f60cbf1862e788e7a4d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5917832
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-10-10 13:19:02 +00:00
Danil Somsikov 29e865259c Report lit-analyzer status correctly so that it can break presubmit 
No-Presubmit: true
Bug: none
Change-Id: I1d360f85a3551e6d9d28030007e502d5ce204d83
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920706
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-10-10 10:21:05 +00:00
Danil Somsikov 868ff924c5 Lint rule enforcing the use of unqalified html template tag. 
lit-analyzer only inspects html`...` not LitHtml.html`...`

No-Presubmit: true
Bug: 370734442
Change-Id: I2ea66f5b0847ce9f04880389fa0197d57aabb0b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921258
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-10 05:40:41 +00:00
Alex Rudenko c8ad1e5573 [AutoFreestyler] Basic side-by-side view for eval 
Two column layout can be improved but it would require more
changes to how rendering works.

Bug: none
Change-Id: Iccceb1f53d406dcac767e2599b5d39da3c4b6750
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920235
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
 2024-10-09 14:36:30 +00:00
Jack Franklin b055020953 Fix use_theme_colors check with outline properties 
Fixed: 371989111
Change-Id: Ib05081d71f93fa4ebb7fd787b6067ac30154a479
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5912682
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2024-10-08 16:53:37 +00:00