zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-19 13:04:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
3,394 Commits 45 Branches 79 Tags
f5e2e5abac33fd04cddc85d2b08dfd348c83b3a7
Commit Graph
379 Commits
Author SHA1 Message Date
Maks Orlovich 5782dc8fcf Add test for _generateBrandVersionList 
Bug: 1073909
Change-Id: I2d9e10ce4e04d8c17df4dd07e3d1d95f23550ccd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198547
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-14 13:50:25 +00:00
Philip Pfaffe e701fe1a41 Reenable tests 
After chromium:1079328 is considered fixed, reenable the affected tests.

Bug: chromium:1079328
Change-Id: I0d7120909ae7434bad950a11307254428e0188cc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199085
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-14 13:43:10 +00:00
Philip Pfaffe c7172a2a68 Disable the flaky Animations Panel test 
The test is turning the tree red.

TBR=tvanderlippe@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1082735
Change-Id: I01454ab9b25a72edf527c1d61b5a46fcda369b79
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2201639
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-14 13:39:56 +00:00
Paul Irish 67aa7a28dd Audits: Roll Lighthouse 6.0.0 (7e4fa5587) 
Built from https://github.com/GoogleChrome/lighthouse/tree/v6
Diff: https://github.com/GoogleChrome/lighthouse/compare/dt-600rc1..v6
Bug: 772558
Change-Id: I9979d26bb09613873b2b65fd293c1b5a8905e009
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2200644
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
 2020-05-14 08:07:24 +00:00
Yang Guo b8584478dd More specific OWNERS where appropriate 
DISABLE_THIRD_PARTY_CHECK=no code change

Change-Id: I02f6ae91f7412c287ecf931e5681c1c882faa26c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2198956
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Reviewed-by: Shane Clifford <shanejc@microsoft.com>
Reviewed-by: Leo Lee <leolee@microsoft.com>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2020-05-14 06:52:14 +00:00
Alex Rudenko 7bf4d03c58 Move overlay implementation to DevTools 
This CL moves the implementation of inspect_tool_highlight.html to
DevTools, sets up a separate resource build target containing code
bundles produced by rollup. Also, it adds size checks and sets up
an example test. The future CLs will cover the rest of inspector tools
and better tests. A follow-up CL for Chromium to use the newly generated
resource is prepared[1].

[1] https://crrev.com/c/2194865

Bug: 1078267
Change-Id: I1c66e3c2aaec04c2f07fab8623d674ada95d8b24
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
 2020-05-14 06:05:14 +00:00
Paul Irish bf20468f57 Audits: Roll Lighthouse 6.0.0-rc.1 (0d6f7e799) 
Adds: desktop scoring for LCP/TBT, Snyk roll, Score calculator link
Fixes: Uses pubads-1.1.0-beta release

Built from https://github.com/GoogleChrome/lighthouse/tree/dt-600rc1
Diff: https://github.com/GoogleChrome/lighthouse/compare/dt-600rc0..dt-600rc1
Bug: 772558
Change-Id: Ib725c3f3a87abe75243051233a2f621e19ee71d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199999
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2020-05-13 23:38:54 +00:00
Jose Leal Chapa 8355052cad Add e2e test for Animations panel 
Bug: 1079076
Change-Id: Iea721a119ea1d36c5e93e13a31e047385778d740
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192317
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-05-13 17:58:45 +00:00
Philip Pfaffe 4ee1521931 Disable the flaky test again 
Test is reddening the tree.

TBR=tvanderlippe@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1073406
Change-Id: Ie48f968d39419b1e6419f7190fcbdcbe6b9426cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2199121
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-13 11:24:22 +00:00
Jack Franklin 7ac7a005a5 Migrate String#toTitleCase to string-utilities 
Bug: 1050549
Change-Id: Ibc0e12d0097c9b5532836f4abcda4a51d39ff843
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193590
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-13 10:57:40 +00:00
Jack Franklin a3d9fc160c Migrate Set.proto.addAll into SetUtilities. 
Bug: 1050549
Change-Id: I2458baf226b55ef5ee8bbc6b4d133cd622763d5c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2194871
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-13 09:45:31 +00:00
Paul Irish ac18cd0f55 Audits: Roll Lighthouse 6.0.0-rc.0 (074ca8c481) 
Built from https://github.com/GoogleChrome/lighthouse/tree/v6dtroll

Bug: 772558
Change-Id: I63ab5367cb5e55776c77d69d1410490e6c6f03c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2197239
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
 2020-05-13 01:37:10 +00:00
Jose Leal Chapa a647ef422b Add e2e test for JavaScript Profiler 
Bug: 1079076
Change-Id: Ifa598cfab9832af32d9c08c2e10305d607a2390d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2195542
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-05-12 16:49:54 +00:00
Sigurd Schneider 4be26cfe83 [issues] Change name of the issues panel to issues tab 
..at least in user-facing places.

Bug: chromium:1057979
Change-Id: Ia43e971d531b01470392f44d5f1f2e51dd40262a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2196025
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-05-12 13:13:24 +00:00
Jack Franklin 631d9264da Migrate Date.prototype.isValid into date-utilities 
Bug: 1050549
Change-Id: I16edff2a7c843ad7a6f246d561b631575044fccc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193589
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-05-12 09:34:53 +00:00
Kim-Anh Tran 380a394d75 Explicitly wait for expected number of files in e2e test 
Bug: chromium:1081150
Change-Id: I256df30243ddeea77c4d7c98209e996eb0638dfc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193959
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2020-05-12 06:46:13 +00:00
Tim van der Lippe 03fe3e7b0f Fix ESLint rule for full relative URL 
Discovered in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193578/1/front_end/sdk/CSSProperty.js#5

R=jacktfranklin@chromium.org

Change-Id: I40225afb5b6018dc99f1d0d7af53ee9016c86e66
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2193953
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-05-11 15:52:50 +00:00
Jose Leal Chapa 75ad85f74b Small improvement to e2e tests 
Respect --test-file flag for e2e tests

Change-Id: Ie9db5c4f41f43fd3741c1c7182319919b3c0a982
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183228
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jose Leal <joselea@microsoft.com>
 2020-05-11 15:45:12 +00:00
Philip Pfaffe 2120ca16b6 Disable the debug-raw-wasm test 
The test has been flaking and coloring the tree read. Disable it for
now.

TBR=kimanh@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1081150
Change-Id: If622f2b8e92e1ea9d344e4f61e41bb7b418e2947
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192895
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-05-11 08:50:59 +00:00
Z Duong Nguyen-Huu 4890aa6fee [wasm] Disallow setting breakpoints on unbreakable lines in WAT 
Toggle non-breakable Wasm Disassembly lines to class of
'cm-non-breakable-line'.
Disallow to put breakpoint in non-breakable WAT as well.

Change-Id: Ib4fbb1cb7728a43790c719a9b12e248cab8bc163
Bug: chromium:1043033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2160000
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
 2020-05-07 17:05:49 +00:00
Sigurd Schneider 668e41db73 [e2e] Disable tests blocking the Chromium binary -> DevTools roll 
This should get the roller Chromium binary -> DevTools working again.

Bug: chromium:1079328
Change-Id: Ide0ff0342eb58037904dde5db949946dbcf8d9c1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2187621
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2020-05-07 16:10:49 +00:00
Tim van der Lippe 7a6062ecf4 Add sentence about running single tests in the e2e runner 
Previously we had the `--test-file` flag to run a single test.
However, since we now use Mocha as the runner, we can use the
`{describe,it}.only` pattern once again. (This previously didn't
work as we were running tests in a worker, which broke Mocha's
test filtering mechanism. This has since been fixed.)

R=joselea@microsoft.com

Change-Id: Iedb90b034cd642cd617f6a51d219d6e40438846a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183915
Commit-Queue: Jose Leal <joselea@microsoft.com>
Reviewed-by: Jose Leal <joselea@microsoft.com>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-07 15:29:59 +00:00
Tim van der Lippe 5b08919a22 Deflake user metrics issues panel test 
Flake observed in https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8881490067054950768/+/steps/E2E_tests/0/stdout
We were using a timeout, which is not reliable on slow hardware.
Instead, we should be waiting for the menuitem to appear,
before clicking it.

R=aerotwist@chromium.org

Change-Id: Iee6638025864e997bfb0d10f38f9b819c64d2d4b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2178579
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-06 12:24:22 +00:00
Jack Franklin 0212512c42 Minor bug fixes to component bridges generator 
* Support string|undefined function return types.
* Add trailing commas to the type definitions.

Change-Id: Ib3379b647ee5ceb404a7c941a850dbce44f2f656
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183918
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-06 12:08:42 +00:00
Jack Franklin 8cfa168b01 Support object literals with interfaces in component bridges 
This change updates the component bridge generation code to understand
object literals and interfaces within them, e.g:

```
set data(data: {x: MyInterface, y: SomeInterface | null})
```

The bridges code understands how to generate the correct `@param`
documentation for that setter, and is able to parse through the object
to find the use of the two interfaces to know that they are interfaces
we need to convert and output in Closure land.

Change-Id: I637309c73721b6a57cd5d06f09600d16bfd207aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2183912
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-06 10:56:42 +00:00
Tim van der Lippe 4b1e8293fd Use Acorn distribution in formatter_worker 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I564fd56105eb6c1ae484f556febc409796701f57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2181217
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-06 10:14:52 +00:00
Alex Rudenko 8405022ddc Reset original color format in computed styles 
Computed styles lack the information about the original format used
for colors and, therefore, we can reset the format to RGB to have the
RGB value formatted properly.

Fixed: chromium:1078299
Change-Id: Ie9a7ad1b10cc96d253de0d627bb9b3cab00a85ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2182424
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-05-05 16:29:48 +00:00
Jack Franklin 66f5c8bf96 Support getters and setters in component bridges generation 
For our components we will use getters and setters to get/set properties
and re-render accordingly. The initial bridges generation work wasn't
built to support get/set methods so this CL adds them.

Change-Id: I1ea55bc0e0c05a8c261f612498c6b52a94d41e8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2179907
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-05-05 14:11:26 +00:00
Wolfgang Beyer 7accf14812 [issues] Fix behaviour of console toolbar linking to issues panel 
Toolbar now shows up even when DevTools are opened after page has
already loaded (no refresh necessary). Page navigation is handled
so that toolbar is displayed for pages with issues and hidden on
pages without issues.

Fixed: chromium:1077700
Change-Id: I9e917db0a12311f7700c4768ddeb5808610f84d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2178580
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2020-05-05 07:19:05 +00:00
Tim van der Lippe 47d0124f61 Remove global createElementWithClass 
This removes the remaining usages of the global createElementWithClass
and its definition. It leaves the `Document.prototype` variant in place
for now, as it is referenced in `devtools_compatibility.js`.

R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I8915e3bb8b6390077f3cd1e41e7c624c7a423aff
Fixed: 1077215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176118
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-04 15:04:06 +00:00
Wolfgang Beyer a03d3df43a [Issues] Add telemetry for how issues panel is being opened 
This CL adds a new metrics enum to allow measuring from where in the
UI the new Issues Panel is being opened.

The corresponding chromium CL is at https://crrev.com/c/2159218

Bug: 1072299
Change-Id: I810a0b40967c8dd84214a1403c500e38a5e4f8f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2157040
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
 2020-05-04 14:50:31 +00:00
Tim van der Lippe 6dcb72d321 Typecheck sdk/NetworkRequest.js with TypeScript 
R=aerotwist@chromium.org

Bug: 1011811
Change-Id: I59b4a3e3c5e81a8905f657ef8de7aef3a60c6a2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2173375
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-04 11:43:51 +00:00
Tim van der Lippe f49e23286b Replace single class invocations of createElementWithClass 
This applies the following replacement to the codebase:

(\S+) = createElementWithClass\('(\w+)', '([^'\s]+)'\);

to

$1 = document.createElement('$2');\n$1.classList.add('$3');

R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1011811, 1077215
Change-Id: I0d76b39f1ed8cd4a44f18f94e398db934ba4b09c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2176112
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-01 16:54:52 +00:00
Tim van der Lippe aa800780e6 Continue with typechecking NetworkManager with TypeScript 
Issues discovered:
- Introduced CONNECTION_TYPES as a Map, as we were using it as an
object before
- Introduce MIME_TYPE enum to specify all mimetypes and strongly
type the getter and setter in NetworkRequest. Sadly we use strings
in other places, so we have to cast these :(
- It turns out that Common.ResourceType.resourceTypes was not
in sync with the protocol mime types. Most notably, it was missing
the `Ping` and `CSPViolationReport` keys. Additionally, it erroneously
includes `SourceMapScript` and `SourceMapStyleSheet` which do not
exist in the protocol. I have kept them in for now, as there is
other code relying on it. However, we should look into removing
them later if they indeed turn out to be obsolete.

R=jacktfranklin@chromium.org,aerotwist@chromium.org

Bug: 1011811
Change-Id: I67b4bba47317fdfab3d724b913465e1be416c6d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2173370
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2020-05-01 13:49:41 +00:00
Tim van der Lippe 4a1da65947 Let Karma fail if generated test file does not exist 
$ npm run unittest

> chrome-devtools-frontend@ unittest /devtools-frontend
> python scripts/test/run_unittests.py --no-text-coverage

Using Chromium binary (/devtools-frontend/third_party/chrome/chrome-mac/Chromium.app/Contents/MacOS/Chromium)

Using karma config /devtools-frontend/out/Default/gen/test/unittests/front_end/karma.conf.js
30 04 2020 15:48:55.262:ERROR [config]: Error in config file!
  Error: Test file /devtools-frontend/test/unittests/front_end/common/Lazy_test.ts is not included in a BUILD.gn and therefore will not be run.
    at /devtools-frontend/out/Default/gen/test/unittests/front_end/karma.conf.js:37:11
    at Array.map (<anonymous>)
    at Object.<anonymous> (/devtools-frontend/out/Default/gen/test/unittests/front_end/karma.conf.js:32:44)
    at Module._compile (internal/modules/cjs/loader.js:955:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:991:10)
    at Module.load (internal/modules/cjs/loader.js:811:32)
    at Function.Module._load (internal/modules/cjs/loader.js:723:14)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.parseConfig (/devtools-frontend/node_modules/karma/lib/config.js:358:22)

R=jacktfranklin@chromium.org
CC=sigurds@chromium.org

Bug: 1061125
Change-Id: I82a52d9de8d01e623ba5542ad922cc579dcbc72a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2174424
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2020-04-30 15:31:26 +00:00
Jack Franklin d0ba31863b Serve images in unit-tests 
Bug: 1076863
Fixed: 1076863
Change-Id: I156cc4af2f870359760a947bf089659b73d89f53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2174300
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-30 14:07:56 +00:00
Jack Franklin 61652d3f24 Move tokenizeFormatString tests to frontend unit test 
These tests existed in a layout test:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/http/tests/devtools/unit/string-util.js.

Once this CL lands I will make a CL to Chromium to remove the layout
test.

Change-Id: Ibc62c2590508176bc4f88faae6ea8df2b31cb8bb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2174419
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-30 13:57:36 +00:00
Mathias Bynens 95e4d1e194 Skip crashing layers panel test 
TBR=janscheffler@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1076763
Change-Id: Iedd59e8d12c99f442d34ef8196b1a823c82d3b8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2172912
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-30 07:54:29 +00:00
Sigurd Schneider 6f49ecb558 [cleanup] Add missing file to BUILD.gn 
A previous change https://crrev.com/c/2120014 introduces a unittest
file, but did not add it to the corresponding BUILD.gn.

This CL adds it thereby enabling the two unittests in that file.

Change-Id: I8a2acfa00c8a22cd10de7e69b64394a63ffc4b1c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2172428
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-29 11:33:16 +00:00
Sigurd Schneider ba81851dad [issues] Add IssueManager abstraction 
This CL adds a central singleton that collects all issues from all
known targers. This singleton is then used by the issues view to
display issues.

This change enables correct handling of issues that arise from OOPIF
and worker sources.

Fixed: chromium:1073797
Change-Id: I75a8bb46d240f63df013c0b06506cad7fb2e5a8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168885
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-29 11:14:55 +00:00
Mathias Bynens f094205392 Improve readability of colorpicker output 
This patch makes the colorpicker output in various formats more
readable by using appropriate unit suffixes where applicable.

For any alpha values, we now use `%` notation since that makes the
range clear (0-100%).

    rgb(0 0 0 / 0.5)
    →→→→→→→→→→→→→→→→
    rgb(0 0 0 / 50%)

For any values that can be expressed in degrees, we were previously
outputting the degrees as a number. This patch adds the `deg` suffix
to make it more clear that the range is 0-360deg.

    hsl(288 92% 31% / 87%)
    →→→→→→→→→→→→→→→→→→→→→→→→→
    hsl(288deg 92% 31% / 87%)

This simplifies the code as well: we can now handle the HSL/HSLA and
RGB/RGBA formats in a single `case`, with just a conditional for the
alpha, as opposed to handling all these cases separately.

Video: https://www.youtube.com/watch?v=anoYaDz0P7k

Upstream test expectation CLs:
- https://chromium-review.googlesource.com/c/chromium/src/+/2172317
- https://chromium-review.googlesource.com/c/chromium/src/+/2172859

Bug: chromium:1075869
Change-Id: I2afad7ccce95d14cbe15e7bf4668281335152bdb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2172417
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2020-04-29 10:58:45 +00:00
Jack Franklin 9c225ca1d9 Extract Number.bytesToString into number-utilities 
Bug: 1050549
Change-Id: Id1d261fbe77d81bcb95886cf78d3e07de24c547a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168883
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-29 10:28:35 +00:00
Kalon Hinds 10b64ff126 Extend ThemeSupport to evaluate CSS variable values 
Edge themes DevTools UI primarily leveraging CSS variables. There are
scenarios where color values need to be used by Canvas elements. In
these situations, we use getComputedStyle to evaluate the element that
has the required CSS variable definitions, since Canvas cannot interpret
CSS variable labels. Currently, getComputedStyle is called independently
for each Canvas scenario. This is not ideal, since getComputedStyle can
be expensive due to causing reflow:
https://gist.github.com/paulirish/5d52fb081b3570c81e3a#getcomputedstyle.

This patch lazily calls getComputedStyle on document.documentElement and caches the
output in ThemeSupport so subsequent Canvases can inexpensively access
computed CSS variable values.

Bug: 961126
Change-Id: If3bcd492e1bf09faf165171c50a073bfad12c35d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2120014
Commit-Queue: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-04-29 02:14:33 +00:00
Jack Franklin 71c1900606 Up e2e timeout to 5 seconds 
Seeing some timeouts on CI and we think the default 2 seconds is too
little and leaves very little wiggle room.

Change-Id: I59b724e284d2f4eee7f0e7e3b011cdb10eda0389
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168878
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2020-04-28 14:30:33 +00:00
Sigurd Schneider 80e9d2ce1c [issues] Introduce the IssueAggregator abstraction 
The IssueAggregator decouples issue aggregation from the SDK layer.
This is a pre-requisit for sourcing issues from multiple IssuesModels,
as aggregation is intended to work across models as well.

Bug: chromium:1073797
Change-Id: Ib25fb27e4baa802471edb83d1a043142dd086765
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165757
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2020-04-28 08:40:21 +00:00
Changhao Han 006b8c05bc Implement Adorner custom element with public API from ElementsTreeElement 
Design doc: https://goo.gle/devtools-adorners

Bug: chromium:1066772
Change-Id: I8b31705471baf7612ac8ed8c305637c366796cf5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2151458
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2020-04-27 20:04:01 +00:00
Kim-Anh Tran d0857958e2 Add test to check if wasm source is shown in sources tab 
Bug: chromium:1071760
Change-Id: Id499be0fd0020e9b73a0391b4952297e2d00e1e5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165753
Reviewed-by: Eric Leese <leese@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2020-04-27 19:46:41 +00:00
Philip Pfaffe e9030b8c54 [e2e] Show chrome stderr/stdout when running e2e tests in debug mode 
Currently we eat all output of chrome in e2e tests. That makes debugging
crashes slightly harder. This CL dumps chrome's IO if debug mode is
enabled.

Change-Id: I3139040c4b47b808b067c2ee4418c07adea10dfb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2168092
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2020-04-27 16:35:56 +00:00
Jack Franklin 93f52244c5 Reland "Move UIString into Platform" 
This is a reland of 992295e37d

Original change's description:
> Move `UIString` into `Platform`
>
> Platform is the "lowest" part of DevTools - e.g. it depends on nothing.
>
> We have code we want to move to Platform but cannot because it needs
> `ls` and therefore creates a circular dependency. So this CL moves
> UIString into Platform.
>
> To avoid rewriting a lot of imports we re-export it from `common.js`.
>
> Change-Id: I399bbe8593e043148c4c7e51f598cbd73a89f639
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165758
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

Change-Id: I482323d1b35eb38066a571cb8630078b6cff6cde
TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165793
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-27 13:59:26 +00:00
Mathias Bynens 6ac9100804 Revert "Move UIString into Platform" 
This reverts commit 992295e37d.

Reason for revert: breaks tree

Original change's description:
> Move `UIString` into `Platform`
> 
> Platform is the "lowest" part of DevTools - e.g. it depends on nothing.
> 
> We have code we want to move to Platform but cannot because it needs
> `ls` and therefore creates a circular dependency. So this CL moves
> UIString into Platform.
> 
> To avoid rewriting a lot of imports we re-export it from `common.js`.
> 
> Change-Id: I399bbe8593e043148c4c7e51f598cbd73a89f639
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165758
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Paul Lewis <aerotwist@chromium.org>

TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org

Change-Id: Ic75fa4dfd49a2c413eee37b03d4c1f54e70eee20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2165789
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
 2020-04-27 12:38:27 +00:00