Commit Graph
147 Commits
Author SHA1 Message Date
Changhao Han 2ec355e93c Add visual hints to the patterns docs
Bug: None
Change-Id: Ie4008dd5549365c8ebcf0637afcacdeb74e471fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171574
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
2025-01-13 04:59:14 -08:00
Changhao Han f856b1657a Add patterns to UX guideline
Bug: None
Change-Id: I7a9dc66990aee65ed5a24677b75ebdd29dbf4e52
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6171573
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
2025-01-13 01:10:22 -08:00
Benedikt Meurer 461ebb8b02 [cleanup] Fix and unify Toolbar.createActionButton.
Bug: 388445687
Change-Id: I39b26edd649c6d783a4eeaf6ddb9265889e643d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6164907
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
2025-01-10 06:50:09 -08:00
Benedikt Meurer c4bb18a354 Unify <select> styling and remove .chrome-select.
With this CL, we remove the `.chrome-select` CSS class and the two
different ways of styling a `<select>` element (excluding the completely
custom thing in the Recorder panel), and only have one set of styles
that we use consistently for all `<select>` elements (modulo the one in
the Recorder panel b/c LitElement), independent of whether the
`<select>` is used in a toolbar or elsewhere.

That means we can now simply put a `<select>` directly into a
`<devtools-toolbar>` and it will work as expected.

Drive-by-fix: Skip the test from crbug.com/383478771 completely now,
since even though the `<select>` in the Recorder panel is unaffected
by these changes, some surrounding (likely) timing changes now make that
test fail consistently, not only on Mac.

Bug: 383478771, 388445687
Change-Id: I01d7835d5858cac8863a7337a8e43a49b55820f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163607
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2025-01-10 00:45:56 -08:00
Wolfgang Beyer 0be8314395 [Docs] Fix image zoom a11y policy doc
The image in [1] was broken, probably because its file size was too
big.

Follow-up to https://crrev.com/c/6105252

[1] https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/policy/gar-page-zoom-policy.md

Bug: none
Change-Id: Iecb81aa890b9c6545f82a8ae3d6be4d777ae6607
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6133120
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
2025-01-02 01:35:47 -08:00
Benedikt Meurer cf629ff396 [cleanup] Remove UI.UItils.registerCustomElement().
As part of the Vision for the Chrome DevTools UI Engineering[^1],
we need to migrate off of built-in custom elements. Which also has
the additional benefit that our UI will work in Safari (part of
this was already fixed with https://crrev.com/c/6028362 earlier).

This CL replaces the previous built-in custom elements with proper
autonomous custom elements: `BezierSwatch`,`DevToolsIconLabel`,
`DevToolsSmallBubble`, and `DevToolsCloseButton`.

The `HistoryInput` component only added special handling for keydown
and input events, and otherwise was just a simple `HTMLInputElement`.
This migrates the class to a simple helper function that does the
same (without requiring a built-in custom element, which we're
trying to migrate off of).

The `DevToolsSlider` and `DevToolsRadioButton` built-in custom
elements are removed in favor of simple helpers that just create
the appropriate `HTMLInputElement`s. The styles for these are
moved to the `inspectorCommon.css`. The custom elements were
really overkill for something trivial as these and only added
confusion. The component server and documentation now also describe
sliders and radio buttons.

This change is functionally neutral and only replaces implementation
details.

Drive-by-fix: Fix a bunch of outdated / incorrect CSS along the way.

[^1]: http://go/chrome-devtools:ui-engineering-proposal

Bug: 386453980
Change-Id: I7ba9f9c156e5f0f9396c0c6eb3d2febc8d371b33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6114579
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-12-30 07:01:54 -08:00
Wolfgang Beyer 4b49feedc8 [Docs] Add page zoom a11y policy doc
Bug: none
Change-Id: If30469eef9bbb61d7234e2ee3116576dd90f4bac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6105252
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-12-23 13:14:37 -08:00
Alex Rudenko 786bd42909 [AI Assistance] Renames and refactorings
Fixed: 380044548
Change-Id: I0c71417a8189a728ff10e9b6504a9887e3f26652
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6080811
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
2024-12-10 11:47:32 +00:00
Benedikt Meurer 061a011cf3 [memory] Fix focus ring and background color for heap source links.
Note that we have to use `!important` here, as the `.text-button` rule
already uses `padding: 0 !important`.

Drive-by-fix: Also add documentation for the `calc(-1 * var(..))`
CSS pattern.

Fixed: 380790928
Change-Id: I4342f092c60cedcc72952a16e55882b7789096ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6041986
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-11-25 15:56:10 +00:00
Benedikt Meurer c60fbc2d1d [docs] Add Slow-Close policy documentation.
Fixed: 380222172
Bug: 380218858
Change-Id: I8f6090c136147038e57a591587bcffb1823ecb46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6037877
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2024-11-21 12:26:48 +00:00
Benedikt Meurer 15caac2b36 [docs] Add number formatting docs to UX Style Guide.
Fixed: 377814746
Bug: 372723536, 357513556
Change-Id: I3a0dd5734effabaf8ba6c8370750ec046aaa7d9c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038157
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-11-20 15:51:44 +00:00
Benedikt Meurer 3d79d1451c [docs] Add shortlink for Chromium Issues Guidelines.
Bug: 354102605
Change-Id: Ie453d6de62cb3f2a051a7c51351c770ee5a3464a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6030930
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2024-11-18 12:53:56 +00:00
Mathias Bynens 5517d77d5a Document that Chrome Canary is is_chrome_branded
- Chrome for Testing releases are built with `is_official_build` + `is_chrome_for_testing_branded`.
- Regular Chrome releases are built with `is_official_build` + `is_chrome_branded`.
- Chromium builds usually have none of these GN args set.

Any features conditional on `is_chrome_branded` are thus not supported in Chromium nor in CfT.

Bug: none
Change-Id: Ia8ecac55d93e2cca9abcb4fa3220293858cd7e17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6021663
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
2024-11-15 14:13:21 +00:00
Benedikt Meurer cc0fd8af29 [docs] Update issue guidelines.
Include the `Infra` subcomponent, and rename `Platform` to `Extensions`.

Bug: none
Change-Id: Ia845414d3871b18460742ef280c7b8645bbe3bdf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6025165
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
2024-11-15 08:38:54 +00:00
Benedikt Meurer 798cfa7b1f [docs] Update T-Shirt Sizes and merge XXS and XS.
The distinction between XXS and XS wasn't useful, but what we often
found necessary was to be able to better distinguish between M and S.
Now S can be used for a (multi-)week effort.

Bug: 368536892
Change-Id: I558d2d68db83702b632f0352eff691c7ad3a1985
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6023183
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2024-11-14 15:04:54 +00:00
Benedikt Meurer e647df66db [docs] Use a go/ link for the internal design docs folder.
This avoids the problem of random people requesting access
to the internal drive folder.

Bug: none
Change-Id: I086069dd55d208237f5db53fce31e295698acd6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5969934
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2024-10-28 06:54:48 +00:00
Simon Zünd 5cfe4e7954 [doc] Update checklist for new javascript features
The CL adds a dedicated section for "async stack traces" and "restart
frame" with updated links.

R=bmeurer@chromium.org

Fixed: 374892098
Change-Id: I09c6a6edfeac11ef05a0aab775a2f0f03f1f58d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5952204
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
2024-10-22 08:27:21 +00:00
Wolfgang Beyer ab4849544d Update link to features.cc in documentation
Bug: none
Change-Id: Id4ab0b292e3236e853075b6d9366ecc24e42f34f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5946883
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
2024-10-21 12:04:11 +00:00
Simon Zünd bf05bd6549 [docs] Update create_new_issue.md with latest information
Also incorporate information about generic issues.

R=bmeurer@chromium.org

Fixed: 374265174
Change-Id: Ic8a21e68ec0080e23bdf3d45799ba277e669ec15
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5941632
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-10-21 07:26:40 +00:00
Benedikt Meurer 52d9f11ff8 [docs] Collect unstructured docs in a cookbook.
Also include the process for creating new issues in the Issues panel
in here.

Bug: 354102605
Change-Id: Ia69ae8141878f62749caffd69d774d0d36baec07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5939823
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
2024-10-18 09:29:15 +00:00
Benedikt Meurer 876be52e0a [docs] Document semantics of T-Shirt Sizes.
Bug: 368536892
Change-Id: I777a126ff3ff38c73aec27679a7b8af39bb9a415
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5921153
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-10-09 13:57:03 +00:00
Benedikt Meurer bc3488d3f3 [docs] Update Visual Logging docs and move it next to the code.
Per Chromium documentation guidelines, module documentation should
ideally live right next to the code to increase both discoverability
and likelyhood of staying up-to-date. Also added a screenshot and
updated the documentation (feature is enabled for a while).

Bug: 40276793
Change-Id: I6063d09ee1b4c996e227493dcaab09ee7fb1ed2b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5902055
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2024-10-02 09:42:10 +00:00
Benedikt Meurer a00b019105 [docs] Consolidate documentation about experiments and features.
Bug: 354102605
Change-Id: I946a3b2115283f2f356a68d94c2f127c25e5cd29
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5895395
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2024-09-30 06:19:51 +00:00
Benedikt Meurer c6aeb207b0 [docs] Add bug reporting guidelines.
Bug: 354102605
Change-Id: I15d13217914503b011e0644e3d92ff55c17ea635
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5860116
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2024-09-13 09:10:33 +00:00
Benedikt Meurer 5f03e5fba2 [docs] Initial version of Issues Guidelines.
Bug: 354102605, 365073443
Change-Id: I2b59e00877248ab7621402eab2ed3e0d16d875e6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5854174
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-09-12 14:56:39 +00:00
Benedikt Meurer 9c3d8c5c10 [docs] Streamling development process documentation.
Bug: 354102605
Change-Id: I87b6e99446be871dd62c41cb49b95f616410c140
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5855507
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2024-09-12 12:32:45 +00:00
Kim-Anh Tran 22d76a1b46 [documentation] Add components (button) and color information
Also-by: kprokopenko, petermueller
Bug: 357513556
Change-Id: Ie42336076e57c75737c3477c97fc210705d9cd01
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5737516
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Peter Müller <petermueller@chromium.org>
Commit-Queue: Peter Müller <petermueller@chromium.org>
2024-09-05 10:36:26 +00:00
Benedikt Meurer 21fa6cab5d [docs] Extend the documentation on creating CLs.
Bug: 354102605
Change-Id: I15eef88d3b7221acc7b990e491357385d0897847
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803110
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2024-08-22 11:53:05 +00:00
Benedikt Meurer c95fb71b5f [docs] Import the Contribution Guide.
The DevTools Contribution Guide previously lived in a notoriously
outdated Google Doc[^1]. This CL migrates it into a Quick Start
section in our main documentation set.

[^1]: https://docs.google.com/document/d/1WNF-KqRSzPLUUfZqQG5AFeU_Ll8TfWYcJasa_XGf7ro

Bug: 354102605
Change-Id: I28c57546a4e16c23f0beb87bcedbcf5e1e9127c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803106
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-08-22 09:42:48 +00:00
Benedikt Meurer 4dc9c70550 [docs] Use public shortlink for UI feature checklist.
Bug: 354102605
Change-Id: I9488c01dd69ad53eb1ba987eb862124912d304c4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803246
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
2024-08-22 07:55:50 +00:00
Benedikt Meurer ff321ef155 [docs] Add a skeleton for the Contribution Guide.
Bug: 354102605
Change-Id: I8f253844aeae4a386f967140a472f4ee12b666f3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803966
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2024-08-22 06:11:19 +00:00
Benedikt Meurer 4385a560a7 [docs] Also import the UI feature checklist for DevTools.
Bug: 354102605
Change-Id: I16a54f2b476d68af44dbdbb45023379856e8c437
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803965
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2024-08-21 13:37:29 +00:00
Benedikt Meurer e8783db223 [docs] Import the Blink, JS, and Wasm checklists.
Bug: 354102605
Change-Id: I4069770864fcb8502e0f5a159d22ffe1312b1cf7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5803197
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2024-08-21 12:16:13 +00:00
Benedikt Meurer 50042c9518 [docs] Use ✔️ and ❌ to improve readability of Dos/Don'ts.
Bug: 354102605
Change-Id: I4628709db30b1b503add35692b187595499c377c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5797060
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-08-21 08:00:46 +00:00
Benedikt Meurer 891f4ceb42 [docs] Import the DevTools TS Style Guide.
This imports go/devtools-tsstyle into the public documentation set.

Bug: 354102605
Change-Id: I67232f1ac56159d36cba5ad4efa577e4e4fa2134
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796833
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2024-08-19 16:05:23 +00:00
Benedikt Meurer ddec15fe87 [docs] Add Chromium DevTools documentation shortlink.
Bug: 354102605
Change-Id: Ie8e9983d7cc60697836cd8c56f2e070a4e81b112
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5788767
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-08-19 08:16:29 +00:00
Benedikt Meurer 5e318981da [docs] Add UX Style Guide shortlink.
Bug: 354102605
Change-Id: I326664d88e739157181198f9599b1c234b870ee9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5776290
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-08-09 13:13:56 +00:00
Benedikt Meurer 73ed7da119 Improve documentation for testing DevTools.
Restructure the current testing documentation with a single
entry point in `test/README.md` and put the E2E and unit test
documentation into a single spot (as much as possible).

There's still room for improvement, but this should give us
a better starting point.

Fixed: 343896438
Change-Id: I2a7881aa2ca7d32c8d20b356ddb7a776c00a5047
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5776289
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2024-08-09 13:05:09 +00:00
Ergun Erdogmus 3b9a31197b [l10n] Collect @meaning tags in messages too to add explicit meanings
The reason I added this was b/343009012 where they
asked us to provide a `meaning` for the message so that
the TC ID will be different than the other `tab` messages.

As a behavior change, if there is a `@meaning` given to the
message, it won't be replaced with its description when there is a
duplicate message.

Fixed: 343009012
Change-Id: Ib45684aee875b8ddcbc3a9b332006d1d61fe3754
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5749082
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
2024-08-01 09:59:52 +00:00
¨Meysam 3d8fb5e750 Chage googlegroup to chromium.org
Bug: none
Change-Id: I523dab10518ae436d4a38910d41f9ac0cd09a9eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729964
Auto-Submit: Meysam Sarabadani <meysarabadani@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2024-07-23 10:40:10 +00:00
Benedikt Meurer 625c4bcd65 [docs] Initial skeleton for the UX Style Guide.
This CL adds an initial skeleton for the UX Style Guide and also
merges the

1. go/chrome-devtools/ux-writing and
2. go/chrome-devtools/ui-glossary

documentation sets into this already, as well as moving and slightly
adjusting the Material 3 styling documentation.

Bug: 354102605
Change-Id: Ida1e5e47038fac421e665eac9785bdc1fe04d6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5725533
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-07-23 07:23:15 +00:00
¨Meysam b63fdcb790 Add committers policy
Bug: none
Change-Id: I9048bc48fbfba662e448099274a72490a689a362
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5729492
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Meysam Sarabadani <meysarabadani@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2024-07-22 12:45:50 +00:00
Benedikt Meurer bf3d9f8403 [docs] Add correct Markdown style guide reference.
Also improve documentation of the Gerrit preview feature.

Bug: 354102605
No-Try: true
Change-Id: I7c886c5ee0636bc714fccd3a4727f99448dd2f76
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5724788
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
2024-07-19 09:24:12 +00:00
Philip Pfaffe 96992fe95a [testing] Make test documentation simpler
Drive-by: Reorder tests when running the full set to run unittests first

Bug: 333423685
Change-Id: I7ac75c7a446fa543d3063a5ac2989fe1f15381b3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688551
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
2024-07-10 05:53:29 +00:00
Jack Franklin 8c5a639cf2 Add VE Logging notes for setVeDebugLoggingEnabled
Bug: none
Change-Id: I25b407bf0d467521f9f663ab6a671b0b46d1bea2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5604431
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2024-06-07 11:07:58 +00:00
Philip Pfaffe 83ecf63b0b [testing] Update docs for the new testing driver
Bug: b:333423685
Change-Id: Ic26581ee2f3f4cb69d067e0f5a8e9e0eeaed7bb0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5466284
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2024-04-19 15:42:40 +00:00
Benedikt Meurer 8b830206ff [docs] Move unit testing documentation into a single place.
Previously the `front_end/testing/README.md` also had some pieces of
information relevant for unit tests, but which wasn't referenced from
our documentation index anywhere. Put that into the proper place.

Bug: 333520272
Change-Id: I8e34c1bf192176e674fc1353fcfce40bef0f3030
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5452879
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2024-04-15 10:28:47 +00:00
Alex Rudenko 2e05f8f1b9 Move devDependencies to package.json
it gives the following benefits:

- go/sk-npm-audit-mirror can perform periodic audits for repo
and auto-file bugs.
- Dev dependencies are declared in a typical location for npm projects.
- allows simplifying manage_node_deps.py the installation by running one `npm install` instead of installing packages one by one.

Bug: chromium:331331303
Change-Id: I7a5486acb89e174be5277c7696cb287a668d2ed7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5423233
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2024-04-05 06:22:21 +00:00
Connor Clark 190b4dfc62 Fix Mac instructions for running with pre-built chrome
Bug: none
Change-Id: I94d1d9a4484df77f0757f92065f6ac8c0b8f5cdf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5319228
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
2024-03-14 22:55:24 +00:00
Benedikt Meurer 4e8561d68f [test] Move unit test documentation.
Bug: b:325903709
Change-Id: If6f77c7fce0229e33f868cc18770050dfacc4195
Doc: http://go/chrome-devtools:move-unit-tests-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5321255
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
2024-02-27 15:11:56 +00:00