Hi everyone,
Our plan for implementing Localization V2 considers 3 phases:
Infrastructure, Migration & Cleaning
This CL is part of the Cleaning phase, it's goal is to remove any
non-standard usage of V1 APIs (outside of the devtools_ui_strings.grd)
I'm splittling these changes into small pieces following this heuristic:
- make sense when logically grouped.
- keep them as small as possible
- can be atomically reverted.
I'll follow up with other changes removing usage on presubmit, scripts
and build.gn files (if any).
Bug: 1136655
Change-Id: I735dc8ba1045ed4afff7deb1a43cf02a7ab55865
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2733640
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
In Lighthouse project, backtick is being used to indicate something that should not be localized.
(See 'inline code block' section in https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n)
We can adopt this with minor modification. When the lighthouse report is being rendered, the backtick in message will be converted to a special html tag and used to style the code snippets. Since we don't want to do special styling for locked terms, backtick can be removed after the term being converted to placeholder in en-US.ctc.json, then locale.json would have the term that is not translated and without the backtick .
For example
Before change: https://imgur.com/a/WqbVbXC
After change: https://imgur.com/a/EZjl6Gg
Note: There is no escape character for using backticks as part of the string, it can only be used for locked terms.
DISABLE_THIRD_PARTY_CHECK=Need to also update README that is in different folder
Bug: 1136655
Change-Id: I68ea305962beec4115d0a50f24e34546b92cadf7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2463990
Commit-Queue: Christy Chen <chrche@microsoft.com>
Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Peter Marshall