Files
Nikolay Vitkov 2a1b3b34b1 Update StyleLint to v16
Stylelint v16 deprecated CJS so I moved our lint script to ESM,
and fixed all the deprecation warning.
The only place I needed to silence them were tests,
as we import CJS there.

Bug: none
Change-Id: Iae4d2df76c855a9738b774a2d035f22509770215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6138610
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2025-01-03 02:57:06 -08:00

52 lines
1.5 KiB
JavaScript

import { RULE_NAME_ALL } from './constants.mjs';
import optionsMatches from './utils/optionsMatches.mjs';
import reportCommentProblem from './utils/reportCommentProblem.mjs';
import validateDisableSettings from './validateDisableSettings.mjs';
/**
* @param {import('stylelint').PostcssResult} postcssResult
* @returns {void}
*/
export default function descriptionlessDisables(postcssResult) {
const [enabled, options] = validateDisableSettings(
postcssResult,
'reportDescriptionlessDisables',
);
if (!options) return;
/** @type {Set<import('postcss').Node>} */
const alreadyReported = new Set();
for (const [rule, ruleRanges] of Object.entries(postcssResult.stylelint.disabledRanges)) {
for (const range of ruleRanges) {
if (range.description) continue;
const node = range.node;
if (alreadyReported.has(node)) continue;
if (enabled === optionsMatches(options, 'except', rule)) {
// An 'all' rule will get copied for each individual rule. If the
// configuration is `[false, {except: ['specific-rule']}]`, we
// don't want to report the copies that match except, so we record
// the comment as already reported.
if (!enabled && rule === RULE_NAME_ALL) alreadyReported.add(node);
continue;
}
alreadyReported.add(node);
reportCommentProblem({
rule: '--report-descriptionless-disables',
message: `Disable for "${rule}" is missing a description`,
severity: options.severity,
node,
postcssResult,
});
}
}
}