mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 17:57:36 +08:00
Tim van der Lippe
01ac2b90b3
This reverts commit 4b654444ed.
Reason for revert: Broke the build in Chromium: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887844056671365856/+/steps/compile__with_patch_/0/stdout
Original change's description:
> Build Karma test with Ninja
>
> This instructs Ninja to generate the appropriate files for the test
> files. It adds a separate `ts_library` definition for tests.
>
> Some caveats:
> - It currently hardcodes the Ninja build output name. We should fix out
> a solution on how to make this irrespective of build name
> - The test name has to be renamed to Color_test.ts. While I think this
> is clearer for code navigation, it was necessary because `ts_library`
> currently copies to `resources/inspector`, which is not necessary for
> test files. We could therefore filter these out, based on the files that
> end with `_test.ts`. We could also add a separate Ninja template,
> something like `ts_test_library`. Not sure yet what is the best
> approach.
>
> DISABLE_THIRD_PARTY_CHECK=Updating TypeScript configuration
>
> Bug: 1011811
> Change-Id: If7448474e84a013d8d4b00a16743575a12112f58
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064669
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org
Change-Id: I1048a5003b5680b257586cf3720fc5eaddb435d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067061
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>