mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 20:39:31 +08:00
Some files currently rely on the Protocol to be available on the global scope. However, the Protocol definitions are defined in a .d.ts file, which isn't available on runtime. Therefore, attempting to import Protocol with non-type imports would retain the imports in the `.js` files and break on runtime. Since the only usages of the Protocol on runtime are the enums, we can make them const, such that they get inlined as intended. Then, `import * as` will work again, as the enums are inlined and the import is removed from the `.js` file. DISABLE_THIRD_PARTY_CHECK=Protocol update R=jacktfranklin@chromium.org Bug: 1208357 Change-Id: I749e57c9f51596866b61cab686c59f00bc8a8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2897277 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>