mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-03 02:21:05 +08:00
Jack Franklin
061f09c304
There are a couple of code changes for us that are relevant: 1.The accuracy of `lib.d.ts` (DOM definitions) has improved, so we have to update a type in `Button.ts`. This changes the type from `X|undefined` to `X|null` so this is very minor. 2. TypeScript got better at understanding conditionals that will always return `true`, and caught a case where we were doing: ``` addEventListener(e => e.key === 'Enter' && Common.Revealer.reveal(...) && false) ``` TS errored because the `reveal()` call is a promise and therefore will always return true, causing the entire expression to return the final `false`. Returning `false` from an event listener doesn't do anything, so I've removed it. DISABLE_THIRD_PARTY_CHECK=required updates to land TS upgrade Bug: none Change-Id: I89ab2ad730d40308da173bd7788c17daf0b4a511 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3757623 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).