mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-30 09:54:02 +08:00
Tim van der Lippe
98a014f2e1
This introduces the first TypeScript-authored file that also makes use of TypeScript features. To do so, we have to perform several steps: 1. Move the `formatter_worker` typescript files into a new template called `devtools_module`. This template takes care of running TypeScript and copying the files it generates to `resources/inspector`. (The latter can be removed when we are in a position to do so) 2. Move the files out of `all_devtools_modules` into (yet another) GN variable. We should clean this up by using the `grd_file_group`, which is possible with an integration with `devtools_module`. However, for simplicity's sake I decided to fix that in a follow-up. The integration of `devtools_module` with the GRD action script would then finally allow us to remove the duplication of all of these file strings in multiple places. 3. To make sure that the buildgraph remains intact, we have to perform the copy-step after the typescript-step. However, this means we need to use a different name than `target_name` for the typescript compilation. We run into issues there, as the project references assume that the names are the full folder names (e.g. `../formatter_worker`). If we would then use a different name for the `ts_library` action, then we generate a `tsconfig.json` with the wrong name. To counteract that, introduce a (temporary) `typescript_config_name` where we can explicitly set the name of the `tsconfig.json` that we generate. This is not ideal and I am still thinking of a better alternative, but haven't figured out a solution yet. DISABLE_THIRD_PARTY_CHECK=Typescript fixes R=aerotwist@chromium.org,jacktfranklin@chromium.org Bug: 1098730 Change-Id: I1457067845cdedbc7d4ce6a80c12d7943b67087c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2282809 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>