Files
react-native-devtools-frontend/front_end/cm_modes/PRESUBMIT.py
T
Erik Luo 66e332cc0c DevTools: fix DevTools docs after blink rename
Renames "WebKit/source" to "blink/renderer" references in DevTools.
Skipping presubmit for protocol.json and CodeMirror (usually
requires words "roll CodeMirror" in description when making changes
in cm/ or cm_modes/).

NOPRESUBMIT=true

Bug: none
Change-Id: Iadb44142a5ae1058dae656b93e904c7636f1fa32
Reviewed-on: https://chromium-review.googlesource.com/1003033
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#549220}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aff59449a34f98ed04cd94547f0ceaaf25d38f71
2018-04-09 18:00:14 +00:00

23 lines
996 B
Python

# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
def _CheckCodeMirrorChanges(input_api, output_api):
errorText = ("ERROR: Attempt to modify CodeMirror. The only allowed changes are "
"rolls from the upstream (http://codemirror.net). If this is a roll, "
"make sure you mention 'roll CodeMirror' (no quotes) in the change description.\n"
"CodeMirror rolling instructions:\n"
" src/third_party/blink/renderer/devtools/front_end/cm/README.md")
changeDescription = input_api.change.DescriptionText()
errors = []
if "roll codemirror" not in changeDescription.lower():
errors.append(output_api.PresubmitError(errorText))
return errors
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CheckCodeMirrorChanges(input_api, output_api))
return results