mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-02 18:11:04 +08:00
Christy Chen
1148dc0fda
In Lighthouse project, backtick is being used to indicate something that should not be localized. (See 'inline code block' section in https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n) We can adopt this with minor modification. When the lighthouse report is being rendered, the backtick in message will be converted to a special html tag and used to style the code snippets. Since we don't want to do special styling for locked terms, backtick can be removed after the term being converted to placeholder in en-US.ctc.json, then locale.json would have the term that is not translated and without the backtick . For example Before change: https://imgur.com/a/WqbVbXC After change: https://imgur.com/a/EZjl6Gg Note: There is no escape character for using backticks as part of the string, it can only be used for locked terms. DISABLE_THIRD_PARTY_CHECK=Need to also update README that is in different folder Bug: 1136655 Change-Id: I68ea305962beec4115d0a50f24e34546b92cadf7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2463990 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org>