mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-05 03:21:16 +08:00
Kim-Anh Tran
8096448354
The `//# sourceURL=something` annotations aren't constraint in any way, and the `something` can literally be any arbitrary string. The sourcemap spec however states that the sourceURL should be resolved relative to the parent documents base URL, which we already do for source-mapped files, but so far hadn't done for files that only contain a sourceURL annotation without also containing a sourceMappingURL annotation. With this change, the ResourceScriptMapping now does that job for standalone scripts as well, similar to what the CompilerScriptMapping does (indirectly via the SourceMapManager) for source-mapped files. Before: https://imgur.com/5WbWyjU.png After: https://imgur.com/S2e89Vj.png Fixed: chromium:1183990 Change-Id: Ibae159867233b52172d187475544d889e491239b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3657449 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
This folder is for Chrome-specific tests only. Tests that should work across browsers should be placed in third_party/blink/web_tests/external/wpt. When using the [integrated checkout workflow](https://chromium.googlesource.com/devtools/devtools-frontend/+/main/docs/workflows.md#Integrated-checkout), web tests from the DevTools repository can be run as via the following command: ```bash third_party/blink/tools/run_web_tests.py -t Default --layout-tests-directory=third_party/devtools-frontend/src/test/webtests/ http/tests/devtools/lighthouse/ ``` For more information about blink tests, please see the Chromium documentation on Web Tests (formerly known as "Layout Tests" or "LayoutTests"): https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_tests.md For more information about web platform tests, please see: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md