mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-29 16:57:00 +08:00
Benedikt Meurer
c4bb18a354
With this CL, we remove the `.chrome-select` CSS class and the two different ways of styling a `<select>` element (excluding the completely custom thing in the Recorder panel), and only have one set of styles that we use consistently for all `<select>` elements (modulo the one in the Recorder panel b/c LitElement), independent of whether the `<select>` is used in a toolbar or elsewhere. That means we can now simply put a `<select>` directly into a `<devtools-toolbar>` and it will work as expected. Drive-by-fix: Skip the test from crbug.com/383478771 completely now, since even though the `<select>` in the Recorder panel is unaffected by these changes, some surrounding (likely) timing changes now make that test fail consistently, not only on Mac. Bug: 383478771, 388445687 Change-Id: I01d7835d5858cac8863a7337a8e43a49b55820f2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163607 Commit-Queue: Danil Somsikov <dsv@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Chromium DevTools docs
This directory contains Chrome DevTools project documentation in Gitiles-flavored Markdown. It is automatically rendered by Gitiles.
If you add new documents, please also add a link to them in the Document Index below.
[TOC]
Document Index
Design Documents
- See the shared Design Documents folder in the Chromium drive.
General Development
- Get the Code
- Contribution Guide
- UX Style Guide
- Testing Guide
- Cookbook
- Visual logging in DevTools
- Style Guides
Architectural Documentation
Chromium
Checklists
- DevTools UI feature checklist
- DevTools support checklist for Blink Intents
- DevTools support checklist for JavaScript features
- DevTools support checklist for WebAssembly features
Policies
Useful Commands
git cl format --js
Formats all code using clang-format.
npm run check
Runs all static analysis checks on DevTools code.
Creating Documentation
Guidelines
- See the Chromium Documentation Guidelines and the Chromium Documentation Best Practices.
- Markdown documents must follow the Markdown style guide.
Previewing changes
Locally using md_browser
Assuming that /path/to/src contains a chromium checkout, you can run:
# in devtools-frontend checkout
/path/to/src/tools/md_browser/md_browser.py --directory $PWD
and preview the result by opening http://localhost:8080/docs/README.md in your browser. This is only an estimate. The gitiles view may differ.
Online with Gerrit's links to gitiles
- Upload a patch to gerrit, or receive a review request. e.g. https://chromium-review.googlesource.com/c/3362532
- View a specific .md file. e.g. https://chromium-review.googlesource.com/c/3362532/2/docs/README.md
- You will see something like
at the top left of the page. Click on the second "preview" link to open the preview for the current patch set.
This gitiles view is the authoritative view, exactly the same as will be used when committed.