mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 01:38:07 +08:00
`waitForFunction` previously always waited 100 ms before checking if the given function is truthy. We can improve the total e2e test suite running time by 40-50 s by eliminating this timeout. This, unfortunately, makes some of the tests flake since they relied on this timeout. This CL attempts to eliminate the timeout and patch the tests that relied on it. In the cases where a test could not be patched the timeout is inserted in the test explicitly. Local experiments showed that this CL reduces the total runtime from on avg. ~309 seconds to an avg. of ~264 seconds. This amounts to a ~45 second reduction or ~15%. This is a reland ofa26e3406c7which was a reland of3be2087f9dBug: 1112692 Change-Id: I3a5156d35553415bfbac95c0251b849ed77f4767 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2354096 Commit-Queue: Johan Bay <jobay@google.com> Reviewed-by: Mathias Bynens <mathias@chromium.org>
Helpers README
// TODO