mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-03 02:21:05 +08:00
Tim van der Lippe
1a0338a117
This reverts commit01ac2b90b3. Reason for revert: Build fixed in Chromium Original change's description: > Revert "Build Karma test with Ninja" > > This reverts commit4b654444ed. > > Reason for revert: Broke the build in Chromium: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887844056671365856/+/steps/compile__with_patch_/0/stdout > > Original change's description: > > Build Karma test with Ninja > > > > This instructs Ninja to generate the appropriate files for the test > > files. It adds a separate `ts_library` definition for tests. > > > > Some caveats: > > - It currently hardcodes the Ninja build output name. We should fix out > > a solution on how to make this irrespective of build name > > - The test name has to be renamed to Color_test.ts. While I think this > > is clearer for code navigation, it was necessary because `ts_library` > > currently copies to `resources/inspector`, which is not necessary for > > test files. We could therefore filter these out, based on the files that > > end with `_test.ts`. We could also add a separate Ninja template, > > something like `ts_test_library`. Not sure yet what is the best > > approach. > > > > DISABLE_THIRD_PARTY_CHECK=Updating TypeScript configuration > > > > Bug: 1011811 > > Change-Id: If7448474e84a013d8d4b00a16743575a12112f58 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064669 > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org > > Change-Id: I1048a5003b5680b257586cf3720fc5eaddb435d5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1011811 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067061 > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> DISABLE_THIRD_PARTY_CHECK=Reland Bug: 1011811 Change-Id: I9df8d551a18c7733fca586f504621c18262e941d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067062 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.