Jack Franklin
1ef4eb754e
This reverts commit f9aef25689.
DISABLE_THIRD_PARTY_CHECK=expected third_party changes with TS fixes
Reason for revert: Currently causing the deterministic bots to fail (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8888105239366430432/+/steps/compare_build_artifacts/0/stdout). Reverting until we understand why and can fix.
We don't rely on this change yet anywhere so we're fine to revert without causing problems elsewhere.
Original change's description:
> Fix TS + Ninja integration
>
> * Tell Closure to autogenerate bridge files
> * Copy _bridge.js files into correct place when generating TypeScript
> * Fix TS Ninja integration to include copied TS generated files
>
> DISABLE_THIRD_PARTY_CHECK=expected third_party changes with TS fixes
>
> Bug: 1011811
> Change-Id: Icbd7574b6bf98b36c8de3be1cb1634b355192e77
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060506
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
TBR=tvanderlippe@chromium.org,jacktfranklin@chromium.org
Change-Id: Iedc3767deac2b6993c26a2c267ba303db0ca4af3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1011811
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2062591
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.