mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-10 05:35:05 +08:00
This CL fixes an issue in Chromium where builds of DevTools cause the
following output:
```
../../third_party/devtools-frontend/src/test/shared/helper.ts:352:44:
352 │ ...tion = runWithDescription.bind(this, description, innerFunction);
│ ~~~~
╵ undefined
This file is considered to be an ECMAScript module because of the "export" keyword here:
```
To avoid this, we can avoid using `this`. The target function
`runWithDescription` is an arrow function, so binding it doesn't make
any difference anyway.
Fixed: 1472963
Change-Id: Ia10b9e832c6fea5b2a41f0ba8286a412b805d39d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4778469
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Helpers README
// TODO