mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-11-01 18:59:10 +08:00
Elorm Coch
6a467df937
This patch ensures the `-theme-with-dark-background` class is only applied when Devtools is in regular Dark Mode or High Contrast Dark Mode. Some forced-active media styles weren't applied after toggling a light HC theme from a Dark Devtools theme. This was because in HC, there needed to be a corresponding css rule with same or higher level of specifity as the css rule in regular Devools Dark theme state (i.e. rules containing -theme-with-dark-background class). The patch takes out this requirement and ensures we revert back to the user's Devtool's theme preference in Devtools after toggling back and forth between HC themes and Devtools Themes. New Behavior: https://i.imgur.com/cDrY8SC.mp4 Bug: 1379182 - Console message links are disappearing in HC light themes Change-Id: I8126469bab04cb6b5d2d360ccbd37d4e1cc4a80c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3988072 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>