mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 17:57:36 +08:00
(...in more than one place). Lots of tests relied on the hosted mode server using port 8090 which is not going to be the case once we have the parallel mocha runner working. Add the port number to puppeteer-state and have tests use it by going through test/shared/helper.ts. The port number is set at runtime rather than being a module-time constant, so some users of the port needed to be changed to get it after the root hooks ran instead. Future users should follow this pattern and get the port in a before() block or during the test itself. Or just use helpers that treat the port properly already e.g. goToResource. We don't send this port number to the hosted mode server yet, so we still have this hardcoded in two places. A fix is coming in a future CL. Bug: 1101784 Change-Id: Ib0a7aa7a25db58d06624a1cdee6fa630cdfbe362 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2284828 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Helpers README
// TODO