mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-02 18:11:04 +08:00
Tim van der Lippe
1a0338a117
This reverts commit01ac2b90b3. Reason for revert: Build fixed in Chromium Original change's description: > Revert "Build Karma test with Ninja" > > This reverts commit4b654444ed. > > Reason for revert: Broke the build in Chromium: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8887844056671365856/+/steps/compile__with_patch_/0/stdout > > Original change's description: > > Build Karma test with Ninja > > > > This instructs Ninja to generate the appropriate files for the test > > files. It adds a separate `ts_library` definition for tests. > > > > Some caveats: > > - It currently hardcodes the Ninja build output name. We should fix out > > a solution on how to make this irrespective of build name > > - The test name has to be renamed to Color_test.ts. While I think this > > is clearer for code navigation, it was necessary because `ts_library` > > currently copies to `resources/inspector`, which is not necessary for > > test files. We could therefore filter these out, based on the files that > > end with `_test.ts`. We could also add a separate Ninja template, > > something like `ts_test_library`. Not sure yet what is the best > > approach. > > > > DISABLE_THIRD_PARTY_CHECK=Updating TypeScript configuration > > > > Bug: 1011811 > > Change-Id: If7448474e84a013d8d4b00a16743575a12112f58 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2064669 > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org > > Change-Id: I1048a5003b5680b257586cf3720fc5eaddb435d5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1011811 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067061 > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> DISABLE_THIRD_PARTY_CHECK=Reland Bug: 1011811 Change-Id: I9df8d551a18c7733fca586f504621c18262e941d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2067062 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
66 lines
1.7 KiB
Python
Executable File
66 lines
1.7 KiB
Python
Executable File
#!/usr/bin/env python
|
|
#
|
|
# Copyright 2019 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""
|
|
Run unit tests on a pinned version of chrome.
|
|
"""
|
|
|
|
import os
|
|
import platform
|
|
import re
|
|
from subprocess import Popen
|
|
import sys
|
|
import signal
|
|
|
|
scripts_path = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
|
sys.path.append(scripts_path)
|
|
|
|
import test_helpers
|
|
import devtools_paths
|
|
|
|
NINJA_BUILD_NAME = os.environ.get('NINJA_BUILD_NAME') or 'Release'
|
|
|
|
|
|
def run_tests(chrome_binary):
|
|
cwd = devtools_paths.devtools_root_path()
|
|
karmaconfig_path = os.path.join(cwd, 'karma.conf.js')
|
|
|
|
exec_command = [devtools_paths.node_path(), devtools_paths.karma_path(), 'start', test_helpers.to_platform_path_exact(karmaconfig_path)]
|
|
|
|
env = os.environ.copy()
|
|
env['NODE_PATH'] = devtools_paths.node_path()
|
|
if (chrome_binary is not None):
|
|
env['CHROME_BIN'] = chrome_binary
|
|
|
|
exit_code = test_helpers.popen(exec_command, cwd=cwd, env=env)
|
|
if exit_code == 1:
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def main():
|
|
chrome_binary = None
|
|
|
|
# Default to the downloaded / pinned Chromium binary
|
|
downloaded_chrome_binary = devtools_paths.downloaded_chrome_binary_path()
|
|
if test_helpers.check_chrome_binary(downloaded_chrome_binary):
|
|
chrome_binary = downloaded_chrome_binary
|
|
|
|
if (chrome_binary is None):
|
|
print('Unable to run, no Chrome binary provided')
|
|
sys.exit(1)
|
|
|
|
print('Using Chromium binary (%s)\n' % chrome_binary)
|
|
|
|
errors_found = run_tests(chrome_binary)
|
|
if errors_found:
|
|
print('ERRORS DETECTED')
|
|
sys.exit(1)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|