mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 04:26:32 +08:00
Songtao Xia
e3af1e3f7d
DevTools has some settings that requires a reloading of DevTools after changing them. If DevTools frontend is undocked, several issues were noticed. 1) device mode button does not work. 2) clicking on "Reload devtools" button, a tab appears instead of that the devtools is reloaded. The cause of the issue is that when "Reload DevTools" is clicked, the reloading logic fails to consider the case when DevTools is undocked. Fix is to use the same logic as frontend.components.reload in frontend.ui. We move the DockController.js from components to ui as 1) ui cannot depend on component and 2) DockController is arguably a legitimate part of ui. The after gif is below, where we tested both cases. https://imgur.com/8LVLPMW Bug: chromium:1105779, chromium:1113601 Change-Id: Ie8e1e60c49ff733de53ab7ad1409d8c44e99162a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2354551 Commit-Queue: Songtao Xia <soxia@microsoft.com> Reviewed-by: Mathias Bynens <mathias@chromium.org>
18 lines
532 B
JavaScript
18 lines
532 B
JavaScript
// Copyright 2019 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import * as ImagePreview from './ImagePreview.js';
|
|
import * as JSPresentationUtils from './JSPresentationUtils.js';
|
|
import * as Linkifier from './Linkifier.js';
|
|
import * as Reload from './Reload.js';
|
|
import * as TargetDetachedDialog from './TargetDetachedDialog.js';
|
|
|
|
export {
|
|
ImagePreview,
|
|
JSPresentationUtils,
|
|
Linkifier,
|
|
Reload,
|
|
TargetDetachedDialog,
|
|
};
|