mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 20:39:31 +08:00
Brian Cui
949ba8ebf4
This CL updates the Console and Issues counters shown in the upper right of DevTools next to the Settings gear icon to be more accessible. - The counter element has changed from a <div> to a <button> element. Previously, the counters were not tab accessible (see bug); the <button> element is tab accessible by default and makes more semantic sense as they open the Console and Issues panels. - The styling has been updated slightly to include a border and hover effect when focused to indicate interactivity. Previously, the only indication that the counters were interactive was the pointer cursor shown upon hover. - The description text (tooltip) is updated to be more clear. We have received reports from users regarding confusion around the meaning of the existing descriptions, e.g. "5 errors, 2 warnings". This text has been changed to explicitly state the interaction outcome, e.g. "Open Console to view 5 errors, 2 warnings". - General code refactors. Before: https://i.imgur.com/waQPBhH.gif After: https://i.imgur.com/zmztxvi.mp4 Bug: 1133060 Change-Id: If0cbc4f58705f3443e480498ca842d68222bc0a9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436646 Commit-Queue: Brian Cui <brcui@microsoft.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Shane Clifford <shanejc@microsoft.com> Reviewed-by: Mathias Bynens <mathias@chromium.org>
37 lines
2.3 KiB
XML
37 lines
2.3 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<grit-part>
|
|
<message name="IDS_DEVTOOLS_26f980b1e673e6e2f478116fa1b378f5" desc="Tooltip shown for a main toolbar button that opens the Lighthouse panel">
|
|
Open Lighthouse to view <ph name="VIOLATIONSUMMARY">$1s<ex>1 violation</ex></ph>
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_3ea4bcbe73ddfe465efc48e7ee7b381a" desc="Issues count title in the Issues Error Counter shown in the main toolbar">
|
|
<ph name="ISSUES">$1s<ex>3</ex></ph> issues
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_5415b9709f6fda34d7148558bbf4e36b" desc="Warning count title in Warning Error Counter of the Console panel">
|
|
<ph name="WARNINGS">$1s<ex>1</ex></ph> warning
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_7cf5ca3a1ac676d518648624fbb35d7e" desc="Tooltip shown for a main toolbar button that opens the Issues panel">
|
|
Open Issues to view <ph name="ISSUESSUMMARY">$1s<ex>1 issue</ex></ph>
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_8e8fda2f7538782b27f82f8ec3c160eb" desc="Warning count title in Warning Error Counter of the Console panel">
|
|
<ph name="WARNINGS">$1s<ex>3</ex></ph> warnings
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_9a075279073f00bab27c1c7612bb9fc0" desc="Error count title in Warning Error Counter of the Console panel">
|
|
<ph name="ERRORS">$1s<ex>3</ex></ph> errors
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_a009c68019d8b4b52469003660f7fb6e" desc="Issues count title in the Issues Error Counter shown in the main toolbar">
|
|
<ph name="ISSUES">$1s<ex>1</ex></ph> issue
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_a1c00c8d8c543411f73883be7ecfb01b" desc="Error count title in Warning Error Counter of the Console panel">
|
|
<ph name="ERRORS">$1s<ex>1</ex></ph> error
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_b042338b60adc2a4dccbc96b2857f939" desc="Tooltip shown for a main toolbar button that opens the Console panel">
|
|
Open Console to view <ph name="CONSOLESUMMARY">$1s<ex>2 errors, 1 warning</ex></ph>
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_dac90a385f9ee1c4d4cac02579d68185" desc="Violation count title in Warning Error Counter of the Console panel">
|
|
<ph name="VIOLATIONS">$1s<ex>1</ex></ph> violation
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_de292077f92bbd36f5b8bd7131f2ef5a" desc="Violation count title in Warning Error Counter of the Console panel">
|
|
<ph name="VIOLATIONS">$1s<ex>3</ex></ph> violations
|
|
</message>
|
|
</grit-part>
|