mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-11-02 11:19:15 +08:00
Michael Liao
a9794c3cfc
Issue: - SwatchPopoverHelper.hide is triggered via focusout/blur event listeners - SwatchPopoverHelper.reposition is triggered via a SizeChanged event through its parent class (ColorSwatchPopoverIcon) - hide will delete this._view and reposition does not handle the case where this._view is undefined - We are exposed to the scenario where the focusout/blur events are queued up before the SizeChanged event - in this scenario, this._view is deleted and causes a failure in reposition(...) Changes: - Protecting against the scenario above by adding a "this._view" check at the beginning of reposition Bug: 1081532 Change-Id: I216dca5b7f27cd302424ba2bd178f2bc206d5381 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2195541 Reviewed-by: Songtao Xia <soxia@microsoft.com> Reviewed-by: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>