react-native-devtools-frontend

mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 12:33:47 +08:00

Files

T

Jack Franklin 947b4d23d6 [DataGrid] fix extra padding on filler row

The data-grid has a filler row that it renders to fill any additional
height of the container, but when the data-grid was filling the height
anyway this row would be 2px high (see screenshot in bug).

This CL changes the row to be 0px high, but I then found an oddness
with the rendering engine (not clear to me if it's desired behaviour
or a bug) where if the table had no rows (so we want the padding row
to be 100% high to fill the space) but then the padding row was given
`padding: 0`, it would not take up any height. Therefore we
conditionally apply an extra CSS class to give the row some padding
such that it takes up extra height in the event of the table being
empty.

Fixed: 1226745
Change-Id: I9030832320eb2554adbac1dc92dfbd8ec4cf9c2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3034608
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

2021-07-19 09:09:20 +00:00

data_grid

[DataGrid] fix extra padding on filler row

2021-07-19 09:09:20 +00:00

data_grid_controller

[DataGrid] focusable cell logic improvements

2021-06-22 12:10:10 +00:00

helpers

Instrument code with Istanbul for interactions tests

2021-05-10 14:44:42 +00:00

tree_outline

Instrument code with Istanbul for interactions tests