mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-27 16:35:54 +08:00

Files

T

Ergün Erdoğmuş ad07a27dbd Revert "Add a global setting for search as you type"

This reverts commit b4643a4703.

Reason for revert: Newly introduced tests are flaky in mac builder[1]

[1]: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Mac/8140/overview

Original change's description:
> Add a global setting for search as you type
>
> Added a global setting to the settings screen and to the command menu
> for enabling search-as-you-type, or requiring Enter for searching,
> in search boxes that support it.
>
> - Added strings, a setting and commands for the new setting.
> - Bailed early on input when the setting is disabled.
> - Tests -
>  - Added general helpers for getting text contents and summoning the
>    search box.
>  - Added elements-panel-specific helpers for the tests.
>  - Made the setting toggle helper accept an optional expected state.
>
> Bug: 1344526
> Change-Id: I75612a54c10d5f40b208084fdbd0ffd7614f7f7c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3859617
> Auto-Submit: PhistucK Productions <phistuck@gmail.com>
> Commit-Queue: PhistucK Productions <phistuck@gmail.com>
> Reviewed-by: Victor Porof <victorporof@chromium.org>
> Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>

Bug: 1344526
Change-Id: I8f9adda6dbca6b4f553cbe6cdd3bffea9088efc2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3865263
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>