mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-22 22:14:39 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
51 lines
1.5 KiB
JavaScript
51 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const optionsMatches = require('./utils/optionsMatches');
|
|
const validateDisableSettings = require('./validateDisableSettings');
|
|
|
|
/** @typedef {import('stylelint').RangeType} RangeType */
|
|
|
|
/**
|
|
* @param {import('stylelint').LintResult[]} results
|
|
*/
|
|
module.exports = function invalidScopeDisables(results) {
|
|
results.forEach((result) => {
|
|
const settings = validateDisableSettings(result._postcssResult, 'reportInvalidScopeDisables');
|
|
|
|
if (!settings) return;
|
|
|
|
const [enabled, options, stylelintResult] = settings;
|
|
|
|
const configRules = (stylelintResult.config || {}).rules || {};
|
|
|
|
const usedRules = new Set(Object.keys(configRules));
|
|
|
|
usedRules.add('all');
|
|
|
|
const rangeData = stylelintResult.disabledRanges;
|
|
const disabledRules = Object.keys(rangeData);
|
|
|
|
disabledRules.forEach((rule) => {
|
|
if (usedRules.has(rule)) return;
|
|
|
|
if (enabled === optionsMatches(options, 'except', rule)) return;
|
|
|
|
rangeData[rule].forEach((range) => {
|
|
if (!range.strictStart && !range.strictEnd) return;
|
|
|
|
// If the comment doesn't have a location, we can't report a useful error.
|
|
// In practice we expect all comments to have locations, though.
|
|
if (!range.comment.source || !range.comment.source.start) return;
|
|
|
|
result.warnings.push({
|
|
text: `Rule "${rule}" isn't enabled`,
|
|
rule: '--report-invalid-scope-disables',
|
|
line: range.comment.source.start.line,
|
|
column: range.comment.source.start.column,
|
|
severity: options.severity,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
};
|