mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-08 04:44:04 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
122 lines
3.7 KiB
JavaScript
122 lines
3.7 KiB
JavaScript
'use strict';
|
|
|
|
const declarationValueIndex = require('../utils/declarationValueIndex');
|
|
const getDeclarationValue = require('../utils/getDeclarationValue');
|
|
const isStandardSyntaxFunction = require('../utils/isStandardSyntaxFunction');
|
|
const report = require('../utils/report');
|
|
const setDeclarationValue = require('../utils/setDeclarationValue');
|
|
const valueParser = require('postcss-value-parser');
|
|
|
|
/** @typedef {import('postcss-value-parser').Node} ValueParserNode */
|
|
/** @typedef {import('postcss-value-parser').DivNode} ValueParserDivNode */
|
|
/** @typedef {(args: { source: string, index: number, err: (message: string) => void }) => void} LocationChecker */
|
|
|
|
/**
|
|
* @param {{
|
|
* root: import('postcss').Root,
|
|
* locationChecker: LocationChecker,
|
|
* fix: ((node: ValueParserDivNode, index: number, nodes: ValueParserNode[]) => boolean) | null,
|
|
* result: import('stylelint').PostcssResult,
|
|
* checkedRuleName: string,
|
|
* }} opts
|
|
*/
|
|
module.exports = function functionCommaSpaceChecker(opts) {
|
|
opts.root.walkDecls((decl) => {
|
|
const declValue = getDeclarationValue(decl);
|
|
|
|
let hasFixed;
|
|
const parsedValue = valueParser(declValue);
|
|
|
|
parsedValue.walk((valueNode) => {
|
|
if (valueNode.type !== 'function') {
|
|
return;
|
|
}
|
|
|
|
if (!isStandardSyntaxFunction(valueNode)) {
|
|
return;
|
|
}
|
|
|
|
// Ignore `url()` arguments, which may contain data URIs or other funky stuff
|
|
if (valueNode.value.toLowerCase() === 'url') {
|
|
return;
|
|
}
|
|
|
|
const argumentStrings = valueNode.nodes.map((node) => valueParser.stringify(node));
|
|
|
|
const functionArguments = (() => {
|
|
// Remove function name and parens
|
|
let result = valueNode.before + argumentStrings.join('') + valueNode.after;
|
|
|
|
// 1. Remove comments including preceding whitespace (when only succeeded by whitespace)
|
|
// 2. Remove all other comments, but leave adjacent whitespace intact
|
|
result = result.replace(/( *\/(\*.*\*\/(?!\S)|\/.*)|(\/(\*.*\*\/|\/.*)))/, '');
|
|
|
|
return result;
|
|
})();
|
|
|
|
/**
|
|
* Gets the index of the comma for checking.
|
|
* @param {ValueParserDivNode} commaNode The comma node
|
|
* @param {number} nodeIndex The index of the comma node
|
|
* @returns {number} The index of the comma for checking
|
|
*/
|
|
const getCommaCheckIndex = (commaNode, nodeIndex) => {
|
|
let commaBefore =
|
|
valueNode.before + argumentStrings.slice(0, nodeIndex).join('') + commaNode.before;
|
|
|
|
// 1. Remove comments including preceding whitespace (when only succeeded by whitespace)
|
|
// 2. Remove all other comments, but leave adjacent whitespace intact
|
|
commaBefore = commaBefore.replace(/( *\/(\*.*\*\/(?!\S)|\/.*)|(\/(\*.*\*\/|\/.*)))/, '');
|
|
|
|
return commaBefore.length;
|
|
};
|
|
|
|
/** @type {{ commaNode: ValueParserDivNode, checkIndex: number, nodeIndex: number }[]} */
|
|
const commaDataList = [];
|
|
|
|
valueNode.nodes.forEach((node, nodeIndex) => {
|
|
if (node.type !== 'div' || node.value !== ',') {
|
|
return;
|
|
}
|
|
|
|
const checkIndex = getCommaCheckIndex(node, nodeIndex);
|
|
|
|
commaDataList.push({
|
|
commaNode: node,
|
|
checkIndex,
|
|
nodeIndex,
|
|
});
|
|
});
|
|
|
|
for (const { commaNode, checkIndex, nodeIndex } of commaDataList) {
|
|
opts.locationChecker({
|
|
source: functionArguments,
|
|
index: checkIndex,
|
|
err: (message) => {
|
|
const index =
|
|
declarationValueIndex(decl) + commaNode.sourceIndex + commaNode.before.length;
|
|
|
|
if (opts.fix && opts.fix(commaNode, nodeIndex, valueNode.nodes)) {
|
|
hasFixed = true;
|
|
|
|
return;
|
|
}
|
|
|
|
report({
|
|
index,
|
|
message,
|
|
node: decl,
|
|
result: opts.result,
|
|
ruleName: opts.checkedRuleName,
|
|
});
|
|
},
|
|
});
|
|
}
|
|
});
|
|
|
|
if (hasFixed) {
|
|
setDeclarationValue(decl, parsedValue.toString());
|
|
}
|
|
});
|
|
};
|