mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 12:33:47 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
176 lines
4.4 KiB
JavaScript
176 lines
4.4 KiB
JavaScript
'use strict';
|
|
|
|
const arrayEqual = require('./arrayEqual');
|
|
const { isPlainObject } = require('is-plain-object');
|
|
|
|
const IGNORED_OPTIONS = new Set(['severity', 'message', 'reportDisables', 'disableFix']);
|
|
|
|
/** @typedef {import('stylelint').RuleOptions} RuleOptions */
|
|
/** @typedef {import('stylelint').RuleOptionsPossible} Possible */
|
|
/** @typedef {import('stylelint').RuleOptionsPossibleFunc} PossibleFunc */
|
|
|
|
/**
|
|
* Validate a rule's options.
|
|
*
|
|
* See existing rules for examples.
|
|
*
|
|
* @param {import('stylelint').PostcssResult} result - postcss result
|
|
* @param {string} ruleName
|
|
* @param {...RuleOptions} optionDescriptions - Each optionDescription can
|
|
* have the following properties:
|
|
* - `actual` (required): the actual passed option value or object.
|
|
* - `possible` (required): a schema representation of what values are
|
|
* valid for those options. `possible` should be an object if the
|
|
* options are an object, with corresponding keys; if the options are not an
|
|
* object, `possible` isn't, either. All `possible` value representations
|
|
* should be **arrays of either values or functions**. Values are === checked
|
|
* against `actual`. Functions are fed `actual` as an argument and their
|
|
* return value is interpreted: truthy = valid, falsy = invalid.
|
|
* - `optional` (optional): If this is `true`, `actual` can be undefined.
|
|
* @return {boolean} Whether or not the options are valid (true = valid)
|
|
*/
|
|
function validateOptions(result, ruleName, ...optionDescriptions) {
|
|
let noErrors = true;
|
|
|
|
optionDescriptions.forEach((optionDescription) => {
|
|
validate(optionDescription, ruleName, complain);
|
|
});
|
|
|
|
/**
|
|
* @param {string} message
|
|
*/
|
|
function complain(message) {
|
|
noErrors = false;
|
|
result.warn(message, {
|
|
stylelintType: 'invalidOption',
|
|
});
|
|
result.stylelint = result.stylelint || {
|
|
disabledRanges: {},
|
|
ruleSeverities: {},
|
|
customMessages: {},
|
|
};
|
|
result.stylelint.stylelintError = true;
|
|
}
|
|
|
|
return noErrors;
|
|
}
|
|
|
|
/**
|
|
* @param {RuleOptions} opts
|
|
* @param {string} ruleName
|
|
* @param {(message: string) => void} complain
|
|
*/
|
|
function validate(opts, ruleName, complain) {
|
|
const possible = opts.possible;
|
|
const actual = opts.actual;
|
|
const optional = opts.optional;
|
|
|
|
if (actual === null || arrayEqual(actual, [null])) {
|
|
return;
|
|
}
|
|
|
|
const nothingPossible =
|
|
possible === undefined || (Array.isArray(possible) && possible.length === 0);
|
|
|
|
if (nothingPossible && actual === true) {
|
|
return;
|
|
}
|
|
|
|
if (actual === undefined) {
|
|
if (nothingPossible || optional) {
|
|
return;
|
|
}
|
|
|
|
complain(`Expected option value for rule "${ruleName}"`);
|
|
|
|
return;
|
|
}
|
|
|
|
if (nothingPossible) {
|
|
if (optional) {
|
|
complain(
|
|
`Incorrect configuration for rule "${ruleName}". Rule should have "possible" values for options validation`,
|
|
);
|
|
|
|
return;
|
|
}
|
|
|
|
complain(`Unexpected option value "${String(actual)}" for rule "${ruleName}"`);
|
|
|
|
return;
|
|
}
|
|
|
|
if (typeof possible === 'function') {
|
|
if (!possible(actual)) {
|
|
complain(`Invalid option "${JSON.stringify(actual)}" for rule ${ruleName}`);
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
// If `possible` is an array instead of an object ...
|
|
if (Array.isArray(possible)) {
|
|
for (const a of [actual].flat()) {
|
|
if (isValid(possible, a)) {
|
|
continue;
|
|
}
|
|
|
|
complain(`Invalid option value "${String(a)}" for rule "${ruleName}"`);
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
// If actual is NOT an object ...
|
|
if (!isPlainObject(actual) || typeof actual !== 'object' || actual == null) {
|
|
complain(
|
|
`Invalid option value ${JSON.stringify(actual)} for rule "${ruleName}": should be an object`,
|
|
);
|
|
|
|
return;
|
|
}
|
|
|
|
for (const [optionName, optionValue] of Object.entries(actual)) {
|
|
if (IGNORED_OPTIONS.has(optionName)) {
|
|
continue;
|
|
}
|
|
|
|
const possibleValue = possible && possible[optionName];
|
|
|
|
if (!possibleValue) {
|
|
complain(`Invalid option name "${optionName}" for rule "${ruleName}"`);
|
|
|
|
continue;
|
|
}
|
|
|
|
for (const a of [optionValue].flat()) {
|
|
if (isValid(possibleValue, a)) {
|
|
continue;
|
|
}
|
|
|
|
complain(`Invalid value "${a}" for option "${optionName}" of rule "${ruleName}"`);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param {Possible | Possible[]} possible
|
|
* @param {unknown} actual
|
|
* @returns {boolean}
|
|
*/
|
|
function isValid(possible, actual) {
|
|
for (const possibility of [possible].flat()) {
|
|
if (typeof possibility === 'function' && possibility(actual)) {
|
|
return true;
|
|
}
|
|
|
|
if (actual === possibility) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
module.exports = /** @type {typeof import('stylelint').utils.validateOptions} */ (validateOptions);
|