Tim van der Lippe
5958eb836f
This also makes cm_modes/ non-remote and uses proper dynamic imports to load the code (rather than an `eval`). This increases the binary size by 104 KB from 11756K to 11860K which is an increase of 0.8%. The stylus cm_mode has been removed. This mode was the largest mode (30KB), seems unmaintained [1] and this syntax is likely rarely used (if at all). It is unclear how often the other modes are installed and used. Additionally, I discovered a promise race in the plugin installation. In the full application this is not noticeable, as by default all code mirror modes are lazily loaded (verified they still work with Markdown, Java file and the regular js/cc files). However, in the test it was not properly awaiting the plugin loading. Perform the async-await plumbing to make sure the promise is resolved before the test continues execution. roll CodeMirror [1]: https://github.com/codemirror/CodeMirror/commits/master/mode/stylus Bug:1006759,1011466 Change-Id: If4d81d01318e08a63faaffee8b0cc9ab5954d4c6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928924 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.