mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-11 14:14:36 +08:00
Brandon Goddard
b9e29f68c2
This CL addresses a bug caused by attempting to autocomplete a suggestion repeatedly when the list of suggestions has not changed. The autocomplete retry was added to fix a bug with filters that use suggestion builders, which change suggestions with successive autocompletes: i.e "m" -> "method:" -> "method:GET" in the network tool filter bar. However, for text prompts with static suggestions, it's possible to get stuck in an autocomplete loop if the user types the full suggestion, then presses "tab" to accept. This CL limits the autocomplete retry to text prompts that use suggestion builders (network filter, console filter, Protocol Monitor filter) Original CL: https://crrev.com/c/2472845 Repro steps available in bug Bug: 1157017 Change-Id: Ifb2c211fb9014c5409a055945493a1c8f50d1db7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2582446 Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>