mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-13 01:54:52 +08:00
Connor Clark
2bc3be29be
This reverts commit0651468562. Reason for revert: Cause of failure has been remedied. See: https://chromium-review.googlesource.com/c/chromium/src/+/2055398 Original change's description: > Revert "[Lighthouse] Rename Audits panel to Lighthouse" > > This reverts commit2ae53ef04d. > > Reason for revert: This CL breaks CI: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/453. It looks like the layout test expects audits not lighthouse in the name, so it's probably in need of a 3-way merge. > > Original change's description: > > [Lighthouse] Rename Audits panel to Lighthouse > > > > Change-Id: Ia2ab175d2a3b6c8ded73aff8ff0f5582f5a8fa0c > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2044605 > > Commit-Queue: Connor Clark <cjamcl@chromium.org> > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Paul Irish <paulirish@chromium.org> > > TBR=paulirish@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org,cjamcl@chromium.org > > Change-Id: Ia6d5f42a0e6ece4352696c51bf0de5754774cb0a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2051983 > Reviewed-by: Paul Lewis <aerotwist@chromium.org> > Commit-Queue: Paul Lewis <aerotwist@chromium.org> TBR=paulirish@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org,cjamcl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1052111 Change-Id: I638ca9bd5cd94e02fb7318f2a7d7c66fca40e6c8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056866 Reviewed-by: Connor Clark <cjamcl@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org>
Adding new icons
- Use Inkscape 0.92 or newer.
- Choose an existing spritesheet, like
largeIcons.svgto add the icon to.
- Make sure to edit the
src/version of the svg!
- Open that file with Inkscape and import the new SVG into the document
- Place in an open spot, and use guides to scale the icon to a good size, relative to other icons
- Any straight lines should be snapped to the closest pixel value.
- Use the
Edit paths by nodestool (F2) to edit the path directly. - Tweak the X, Y values at the top to be integers.
- Use the
- Optimize SVGs:
./scripts/optimize_svg_images.py
- In
ui/Icon.jsadd an entry inUI.Icon.Descriptors.- Look at the spritesheet's axes to identify the correct grid position.
- You may want to regenerate devtools resources:
ninja -C ~/chromium/src/out/Release/ devtools_frontend_resources