mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 04:26:32 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
107 lines
2.8 KiB
JavaScript
107 lines
2.8 KiB
JavaScript
'use strict';
|
|
|
|
/** @typedef {import('stylelint').Problem} Problem */
|
|
|
|
/**
|
|
* Report a problem.
|
|
*
|
|
* This function accounts for `disabledRanges` attached to the result.
|
|
* That is, if the reported problem is within a disabledRange,
|
|
* it is ignored. Otherwise, it is attached to the result as a
|
|
* postcss warning.
|
|
*
|
|
* It also accounts for the rule's severity.
|
|
*
|
|
* You *must* pass *either* a node or a line number.
|
|
* @param {Problem} problem
|
|
* @returns {void}
|
|
*/
|
|
function report(problem) {
|
|
const ruleName = problem.ruleName;
|
|
const result = problem.result;
|
|
const message = problem.message;
|
|
const line = problem.line;
|
|
const node = problem.node;
|
|
const index = problem.index;
|
|
const word = problem.word;
|
|
|
|
result.stylelint = result.stylelint || {
|
|
ruleSeverities: {},
|
|
customMessages: {},
|
|
};
|
|
|
|
// In quiet mode, mere warnings are ignored
|
|
if (result.stylelint.quiet && result.stylelint.ruleSeverities[ruleName] !== 'error') {
|
|
return;
|
|
}
|
|
|
|
// If a line is not passed, use the node.positionBy method to get the
|
|
// line number that the complaint pertains to
|
|
// @ts-expect-error -- The type of `Node.prototype.positionBy()` is not be exposed.
|
|
const startLine = line || node.positionBy({ index }).line;
|
|
|
|
const { ignoreDisables } = result.stylelint.config || {};
|
|
|
|
if (result.stylelint.disabledRanges) {
|
|
const ranges = result.stylelint.disabledRanges[ruleName] || result.stylelint.disabledRanges.all;
|
|
|
|
for (const range of ranges) {
|
|
if (
|
|
// If the problem is within a disabledRange,
|
|
// and that disabledRange's rules include this one,
|
|
// do not register a warning
|
|
range.start <= startLine &&
|
|
(range.end === undefined || range.end >= startLine) &&
|
|
(!range.rules || range.rules.includes(ruleName))
|
|
) {
|
|
// Collect disabled warnings
|
|
// Used to report `needlessDisables` in subsequent processing.
|
|
const disabledWarnings =
|
|
result.stylelint.disabledWarnings || (result.stylelint.disabledWarnings = []);
|
|
|
|
disabledWarnings.push({
|
|
rule: ruleName,
|
|
line: startLine,
|
|
});
|
|
|
|
if (!ignoreDisables) {
|
|
return;
|
|
}
|
|
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
const severity = result.stylelint.ruleSeverities && result.stylelint.ruleSeverities[ruleName];
|
|
|
|
if (!result.stylelint.stylelintError && severity === 'error') {
|
|
result.stylelint.stylelintError = true;
|
|
}
|
|
|
|
/** @type {import('stylelint').WarningOptions} */
|
|
const warningProperties = {
|
|
severity,
|
|
rule: ruleName,
|
|
};
|
|
|
|
if (node) {
|
|
warningProperties.node = node;
|
|
}
|
|
|
|
if (index) {
|
|
warningProperties.index = index;
|
|
}
|
|
|
|
if (word) {
|
|
warningProperties.word = word;
|
|
}
|
|
|
|
const warningMessage =
|
|
(result.stylelint.customMessages && result.stylelint.customMessages[ruleName]) || message;
|
|
|
|
result.warn(warningMessage, warningProperties);
|
|
}
|
|
|
|
module.exports = /** @type {typeof import('stylelint').utils.report} */ (report);
|