mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-10 05:35:05 +08:00
Jack Lynch
6790102aae
This change makes the javascript breakpoints pane accessible by: - adding an option to the context menu to reveal the location of a breakpoint for keyboard users - allowing keyboard users to navigate the breakpoints list with the arrow keys by refactoring the pane to use UI.ListControl, in response to feedback on [1] - putting the checked/unchecked status of a breakpoint and whether it has been hit in its aria-describedby These changes break a few web tests, so [2] must be merged first to disable them. Test fixes are here [3]. Screenshots: Context menu: https://gyazo.com/3f54dd9a1fd146270a64afd635cf2bc6 Hit breakpoint: https://gyazo.com/8363b986f36f67a213170dad73ba0450 Keyboard navigation video: https://i.imgur.com/ZOvVrxf.mp4 [1] https://chromium-review.googlesource.com/c/chromium/src/+/1644461/14/third_party/blink/renderer/devtools/front_end/browser_debugger/DOMBreakpointsSidebarPane.js#141 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1894751 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1636716 Bug: 963183 Change-Id: I360c828145806a1133937ce8c6f2e4885cb0f900 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
49 lines
1.0 KiB
CSS
49 lines
1.0 KiB
CSS
/*
|
|
* Copyright 2017 The Chromium Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
.breakpoint-entry {
|
|
padding: 3px 8px 3px 8px;
|
|
min-height: 18px;
|
|
line-height: 15px;
|
|
border-top: 1px solid #efefef;
|
|
}
|
|
|
|
.breakpoint-entry:focus {
|
|
background-color: var(--focus-bg-color);
|
|
}
|
|
|
|
.breakpoint-entry [is=dt-checkbox] {
|
|
max-width: 100%;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
:not(.breakpoints-list-deactivated) > .breakpoint-entry:hover {
|
|
background-color: #eee;
|
|
}
|
|
|
|
.breakpoint-entry > .source-text {
|
|
cursor: pointer;
|
|
text-overflow: ellipsis;
|
|
overflow: hidden;
|
|
white-space: nowrap;
|
|
margin-left: 22px;
|
|
}
|
|
|
|
.breakpoints-list-deactivated {
|
|
background-color: #eee;
|
|
opacity: 0.3;
|
|
}
|
|
|
|
.breakpoint-hit {
|
|
background-color: rgb(255, 255, 194);
|
|
border-right: 3px solid rgb(107, 97, 48);
|
|
}
|
|
|
|
:host-context(.-theme-with-dark-background) .breakpoint-hit {
|
|
background-color: hsl(46, 98%, 22%);
|
|
color: #ccc;
|
|
}
|