Tim van der Lippe
6d51bf00ea
front_end/Runtime.js was doing multiple things: it was instantiating side-effecty descriptors and initializing applications, as well as storing all state for the modules/extensions, etc... To support proper ES Modules, we need to separate these. root/Runtime.js contains simple classes that store the data and can be retrieved, as well as some helper functions that will load the respective data. The RuntimeInstantiator.js code includes the start functions used in the entrypoints themselves. They will use an instance of the Runtime to properly load the application. Along the way, I also fixed various TypeScript errors, mostly around incorrect or missing type definitions. R=aerotwist@chromium.org,jacktfranklin@chromium.org Bug: 1011811 Change-Id: If3ddea9267813691b3faeb6ea4b0cf64edbde1f4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107523 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.