mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-30 09:17:09 +08:00
devtools-plugin for rollup should not treat code inside Puppeteer folders as DevTools entrypoints. Only the `frontend/third_party/puppeteer/puppeteer.js` and `frontend/third_party/puppeteer-replay/puppeteer-replay.js` should be treated as entry points. Fixed: 1470202 Change-Id: Ic9c6344f163bc23f5b1d04c936c0446bb07c4d0e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4765265 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org>
151 lines
5.0 KiB
JavaScript
151 lines
5.0 KiB
JavaScript
// Copyright 2022 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// @ts-check
|
|
|
|
const path = require('path');
|
|
|
|
/**
|
|
* `path.dirname` does not include trailing slashes. If we would always
|
|
* use `path.dirname` and then later perform comparisons on the paths that
|
|
* it returns, we could run into false positives. For example, given the
|
|
* the following two paths:
|
|
*
|
|
* front_end/timeline_model/TimelineModel.js
|
|
* front_end/timeline/Timeline.js
|
|
*
|
|
* And that would have the following values for `path.dirname`:
|
|
*
|
|
* front_end/timeline_model
|
|
* front_end/timeline
|
|
*
|
|
* If we would do a simple `.startswith` on the `path.dirname` of both of
|
|
* these paths, then the first path would start with the dirname of the
|
|
* second. However, they *are* part of different folders. To fix that problem,
|
|
* we need to force a path separator after each folder. That makes sure we
|
|
* and up with the following comparison of path dirnames:
|
|
*
|
|
* front_end/timeline_model/
|
|
* front_end/timeline/
|
|
*
|
|
* Now, the first path does *not* start with the second one, as expected.
|
|
*
|
|
* @param {string} file
|
|
* @return {string}
|
|
*/
|
|
function dirnameWithSeparator(file) {
|
|
return path.dirname(file) + path.sep;
|
|
}
|
|
|
|
function devtoolsPlugin(source, importer) {
|
|
if (!importer) {
|
|
return null;
|
|
}
|
|
|
|
if (source === '../../lib/codemirror' || !source.startsWith('.')) {
|
|
// These are imported via require(...), but we don't use
|
|
// @rollup/plugin-commonjs. So this check is not necessary for rollup. But
|
|
// need to have this for esbuild as it doesn't ignore require(...).
|
|
return {
|
|
id: source,
|
|
external: true,
|
|
};
|
|
}
|
|
|
|
const currentDirectory = path.normalize(dirnameWithSeparator(importer));
|
|
const importedFilelocation = path.normalize(path.join(currentDirectory, source));
|
|
const importedFileDirectory = dirnameWithSeparator(importedFilelocation);
|
|
|
|
// Generated files are part of other directories, as they are only imported once
|
|
if (path.basename(importedFileDirectory) === 'generated') {
|
|
return null;
|
|
}
|
|
|
|
// An import is considered external (and therefore a separate
|
|
// bundle) if its filename matches its immediate parent's folder
|
|
// name (without the extension). For example:
|
|
// `import * as Components from './components/components.js'` = external
|
|
// `import * as UI from '../ui/ui.js'` = external
|
|
// `import * as LitHtml from '../third_party/lit-html/lit-html.js'` = external
|
|
// `import {DataGrid} from './components/DataGrid.js'` = not external
|
|
// `import * as Components from './components/foo.js'` = not external
|
|
|
|
// Note that we can't do a simple check for only `third_party`, as in Chromium
|
|
// our full path is `third_party/devtools-frontend/src/`, which thus *always*
|
|
// includes third_party. It also not possible to use the current directory
|
|
// as a check for the import, as the import will be different in Chromium and
|
|
// would therefore not match the path of `__dirname`.
|
|
// These should be removed because the new heuristic _should_ deal with these
|
|
// e.g. it'll pick up third_party/lit-html/lit-html.js is its own entrypoint
|
|
|
|
// The CodeMirror addons look like bundles (addon/comment/comment.js) but are not.
|
|
if (importedFileDirectory.includes(path.join('front_end', 'third_party', 'codemirror', 'package'))) {
|
|
return null;
|
|
}
|
|
|
|
// The LightHouse bundle shouldn't be processed by `terser` again, as it is uniquely built
|
|
if (importedFilelocation.includes(path.join('front_end', 'third_party', 'lighthouse', 'lighthouse-dt-bundle.js'))) {
|
|
return {
|
|
id: importedFilelocation,
|
|
external: true,
|
|
};
|
|
}
|
|
|
|
if (importedFileDirectory.includes(path.join('front_end', 'third_party', 'puppeteer', 'package'))) {
|
|
return {
|
|
id: importedFilelocation,
|
|
external: false,
|
|
};
|
|
}
|
|
|
|
if (importedFileDirectory.includes(path.join('front_end', 'third_party', 'puppeteer-replay', 'package'))) {
|
|
return {
|
|
id: importedFilelocation,
|
|
external: false,
|
|
};
|
|
}
|
|
|
|
const importedFileName = path.basename(importedFilelocation, '.js');
|
|
const importedFileParentDirectory = path.basename(path.dirname(importedFilelocation));
|
|
const isExternal = importedFileName === importedFileParentDirectory;
|
|
|
|
return {
|
|
id: importedFilelocation,
|
|
external: isExternal,
|
|
};
|
|
}
|
|
|
|
function esbuildPlugin(outdir) {
|
|
return args => {
|
|
// args.importer is absolute path in esbuild.
|
|
const res = devtoolsPlugin(args.path, args.importer);
|
|
if (!res) {
|
|
return null;
|
|
}
|
|
|
|
if (res.external) {
|
|
// res.id can be both of absolutized local JavaScript path or node's
|
|
// builtin module (e.g. 'fs', 'path'), and only relativize the path in
|
|
// former case.
|
|
if (path.isAbsolute(res.id)) {
|
|
res.id = './' + path.relative(outdir, res.id);
|
|
}
|
|
|
|
return {
|
|
external: res.external,
|
|
path: res.id,
|
|
};
|
|
}
|
|
|
|
return {
|
|
path: res.id,
|
|
};
|
|
};
|
|
}
|
|
|
|
module.exports = {
|
|
devtoolsPlugin,
|
|
esbuildPlugin
|
|
};
|