Tim van der Lippe
719446c0db
The TypeScript compiler has a bug where, when you implement an interface in JSDoc which is defined in a `.d.ts` file which uses a namespace, it generates an invalid declaration file [1]. To workaround this bug, we have to add global interfaces that are essentially aliases of the actual interfaces. As a result, the TypeScript compiler no longer fails with resolving. Update Closure accordingly such that we can use the correct type to work in both Closure and TypeScript. [1]: https://github.com/microsoft/TypeScript/issues/38640 R=jacktfranklin@chromium.org,aerotwist@chromium.org CC=sigurds@chromium.org,janscheffler@chromium.org Bug: 1081686, 1011811 Change-Id: I088a4520c90ce0873cf9850a8ed65f9c8dd896ef Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2208978 Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.