mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-08 12:53:45 +08:00
Tim van der Lippe
74e4acb702
In https://crrev.com/c/2684274 the layout tests will use the gen build output of DevTools. The layout tests are still failing ( https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8855048827859077360/+/steps/blink_web_tests__with_patch_/0/logs/outdir_json/0 ) with the following error: ``` PROMISE FAILURE: Error: While loading from url http://localhost:8000/inspector-sources/i18n/locales/en-US.json server responded with a status of 404 at XMLHttpRequest.n.onreadystatechange (http://localhost:8000/inspector-sources/root/root.js:1:8457) ``` As it turns out, we need to explicitly list the locales as `data` as well. Rather than updating the `filter_include` to include `*.json` (which would cause it to include `tsconfig.json` files, which we don't want), we should instead only include the mapped sources in the gen-directory. We also can't use the `invoker.sources` array directly, as that would include `*.ts` files, which don't have a corresponding `gen` build output file. That would crash the CQ bots as well, as they ensure that all `runtime_deps` files exist. R=jacktfranklin@chromium.org Bug: 1174013 Change-Id: I35623e86c40f5616836c1387c150fc492db527e6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2700391 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>