mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-02 18:11:04 +08:00
Simon Zünd
7342aa3a71
This CL extends the 'evaluateExpressionsWithSourceMaps' to
conditional breakpoints. To make this work, we call the newly
added 'allVariablesAtPosition' NameResolver that works
independent of the page being paused or not.
We apply the variable substitution on the ModelBreakpoint level
and only if we have a concrete `SDK.Script` instance. This means
that if the same authored code shows up in different bundles
with different variable names, we'll do the substitution per
bundle correctly.
Note that 'Breakpoint#backendCondition()' now has two overloads:
1) If no location is passed in, we don't substitute variables.
In this case there is no async work so we return no promise.
2) If a location is passed in and the experiment is enabled we
return a promise since variable substitution can take some
time.
We implemented 'backendCondition' this way because otherwise we'd
have to propagate async/await up the call-chain and in some places
we want to keep things synchronous (e.g. initalizing the
BreakpointManager).
As a follow-up we should store the calculated backend condition
also in the storage state, so that when we set breakpoints
eagerly on DevTools startup, we can send the substituted condition.
R=jarin@chromium.org
Bug: 1444349
Change-Id: I59af6fbfe39ce08daff1f4662342542e0199bd12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4675896
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>