Files
react-native-devtools-frontend/front_end/Images
Michael Liao 4f62c670fe [Icon]: Change dropdown arrow to svg and add dark theme dropdown arrow
Issue:
- chrome-select inputs have slightly blurry dropdown arrow
- chrome-select inputs in dark theme have a hard to see dropdown arrow due to contrast

Changes:
- changing dropdown arrow icons to .svg
- adding dark theme dropdown arrow

Pictures:

Before - Settings in Dark Theme: https://imgur.com/NePBXu6
After - Settings in Dark Theme: https://imgur.com/aGjk7UM

Before - Settings in Light Theme: https://imgur.com/78VAoee
After - Settings in Light Theme: https://imgur.com/kLCyEqM

Bug: 1164031
Change-Id: I2d7c10788692cf973e24a23f4c22b12e22a26919
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2616383
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
2021-01-11 19:03:56 +00:00
..
2020-10-14 15:04:42 +00:00
2020-07-16 10:18:25 +00:00
2019-06-10 23:19:12 +00:00
2019-06-10 23:19:12 +00:00
2019-06-10 23:19:12 +00:00
2020-10-14 15:04:42 +00:00
2020-05-18 15:59:12 +00:00
2020-12-07 10:19:20 +00:00
2019-06-10 23:19:12 +00:00

Adding new icons:

  1. Out of a spritesheet (if you have a separately saved icon already go to 2.):

    • Open a spritesheet with the icon of interest, like largeIcons.svg in Inkscape.
    • Make sure it's the src/ version of the spritesheet.
    • Copy-paste the icon to a new page. Make sure it preserved its original size and aspect ratio, and isn't otherwise altered.
    • To make sure step (3) below doesn't destroy the icon, it might be necessary to resize it. Just select everything and use the elements in the top toolbar to resize the icon (make sure the aspect ratio is preserved).
    • Set the size of the page to match the icon. You may use Inkscape's Edit>Resize Page to Selection command to accomplish this.
    • If you chose to include padding in the icon, make sure the icon is centered within the page.
    • Save the icon with _icon.svg suffix. For instance list_icon.svg.
  2. Add respective entries to .gni files.

    • Update the devtols_image_files list in devtools_image_files.gni.
    • Update the grd_files_release_sources list in devtools_grd_files.gni.
  3. Optimize:

    • ./scripts/optimize_svg_images.py.
    • This script produces, for example, Images/list_icon.svg from Images/src/list_icon.svg by rounding numbers and removing hopefully unnecessary content. However, it might end up distorting/destroying the icon, especially if it is too small. Make sure to open the output of the optimiztion process (e.g. Images/list_icon.svg) in Inkscape and inspect it for damage. Enlarging the input image, as desribed in step (1) usually circumvents this.
  4. Use Icon component in the DevTools front-end: