mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-09 21:28:43 +08:00
Tim van der Lippe
5511047da1
The inspector-stylesheet is a special virtual file that is used to keep track of any new CSS rules, which can be added by clicking the "New Style Rule" button in the Elements panel. However, the changes computation broke and was no longer showing any changes to this file. The most likely culprit is https://crrev.com/c/2378070 which changed the way errors were handled. The TLDR is that the `baseline` became an empty string, which is falsy. Hence, the diff computation bailed and was not showing any diffs. Instead, we should be explicitly checking of the `baseline` is `null`, since it is legal to perform a diff computation between an empty string and a larger string. R=szuend@chromium.org Fixed: 1152507 Change-Id: I1aa778e7922586a4381cbc1e1e6e543a5ccffdd9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2610964 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>