vidorteg
8bce4b0b83
Root cause: i18n is designed to work with strings that are declared in a UIStrings object on the SAME file where they are being used. To my best knowledge this is done to improve performance when searching for a translation, but in Devtools there are strings that live in module.json files and are exposed to i18n via a ModuleUIStrings.js file. Fix: There is already a mechanism for this kind of templating in the i18n library which exposes a small subset of translations that match a specific pattern, the fix is to change this pattern to match ModuleUIStrings and to also include this as part of the translation resolution. Change-Id: If44a84a9b5892558bf832e6d08ea36d1a8f4ddd1 Bug: 1136655 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2459638 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.